Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: minor fix for ReadableState #11139

Closed
wants to merge 2 commits into from
Closed

stream: minor fix for ReadableState #11139

wants to merge 2 commits into from
+4 −8

Conversation

@cynron
Copy link
Contributor

@cynron cynron commented Feb 3, 2017 •
edited

  1. remove unused flag ranOut from ReadableState, ranOut had been unused since 0f8de5e

  2. fix the comments for flag sync of ReadableState.

Checklist
  • make -j4 test (UNIX) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • stream
Wang Xinyong added 2 commits Feb 3, 2017
Wang Xinyong
stream: remove unused ranOut from ReadableState
3a43698 
flag `ranOut` became unused since 0f8de5e,
but 0f8de5e did not remove it.
Wang Xinyong
stream: fix comments for sync flag of ReadableState
5315409 
It seems that the comments for sync flag of ReadableState is
copied from WritableState without modification.
@cynron cynron changed the title Minor fix for ReadableState stream: minor fix for ReadableState Feb 3, 2017
@addaleax
addaleax approved these changes Feb 3, 2017
View changes
@addaleax
Copy link
Member

@addaleax addaleax commented Feb 3, 2017

CI: https://ci.nodejs.org/job/node-test-commit/7647/
@jasnell
Copy link
Member

@jasnell jasnell commented Feb 3, 2017

@nodejs/streams
@jasnell
Copy link
Member

@jasnell jasnell commented Feb 3, 2017

Given that this removes a property, this is potentially semver-major. It shouldn't be, but we need to be certain.
@mcollina
Copy link
Member

@mcollina mcollina commented Feb 3, 2017

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/563/
@mcollina
mcollina approved these changes Feb 3, 2017
View changes
@mcollina
Copy link
Member

@mcollina mcollina commented Mar 3, 2017

I think we are going to release this as semver-minor in readable-stream. If that does not cause issues, we can release this as semver-minor also in Node.

ReadableState  is undocumented atm.
@mcollina
Copy link
Member

@mcollina mcollina commented Mar 3, 2017

Landed as 1004b9b and 202b07f
@mcollina mcollina closed this Mar 3, 2017
mcollina added a commit that referenced this pull request Mar 3, 2017
Wang Xinyong @mcollina
stream: remove unused ranOut from ReadableState
1004b9b 
flag `ranOut` became unused since 0f8de5e,
but 0f8de5e did not remove it.

PR-URL: #11139
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
mcollina added a commit that referenced this pull request Mar 3, 2017
Wang Xinyong @mcollina
stream: fix comment for sync flag of ReadableState
202b07f 
It seems that the comment for sync flag of ReadableState is
copied from WritableState without modification.

PR-URL: #11139
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

@addaleax addaleax commented Mar 4, 2017

@mcollina Just ICYMI, our current policy is that at least 2 CTC members need to sign off on semver-major changes before landing them. I don’t think that’s a problem here because it’s not something that’s really covered by our API (as you pointed out)… I just added the label because, at least from Node’s perspective, I don’t think there’s a reason to not consider this semver-major.
@mcollina
Copy link
Member

@mcollina mcollina commented Mar 4, 2017

Oh, I thought this was sitting there for a while, and just reduced the pull requests count by one.
Thanks for noting.
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@addaleax addaleax

Assignees
No one assigned
Labels
semver-major stream
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@cynron @addaleax @jasnell @mcollina @nodejs-github-bot