Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Publish to GitHub" link button with button #570

Merged
merged 6 commits into from Oct 13, 2016

Conversation

@paladique
Copy link
Collaborator

@paladique paladique commented Sep 29, 2016

newbutton

Fixes #551

@shana
Copy link
Collaborator

@shana shana commented Oct 4, 2016

Woot! 😄

Could you post a screenshot of the light and dark themes the includes the rest of the Team Explorer pane, so we can see how it looks with the rest of the UI?

@paladique
Copy link
Collaborator Author

@paladique paladique commented Oct 5, 2016

Added in what they look like when highlighted as well

Light Theme

capture
capture-h

Blue Theme

capture2
capture2-h

Dark Theme

capture3
capture3-h

@shana
Copy link
Collaborator

@shana shana commented Oct 13, 2016

Looks great!
It looks like the VsButtonStyleKey style does not match the TE button styles. This is used now in the invitation section and also in the publish section, so we should fix it. Opened issue #599 to track it.

@shana shana merged commit 5eed546 into master Oct 13, 2016
5 checks passed
5 checks passed
GitHub CLA @paladique has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #4403684 succeeded in 87s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details
@shana shana deleted the fixes/551-link-to-button branch Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.