Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore this PR, do not merge, it's a test PR for github #327

Closed
wants to merge 236 commits into from

Conversation

@shana
Copy link
Collaborator

@shana shana commented May 26, 2016

Nothing to see here, move along

shana added 30 commits Oct 6, 2015
For concurrent ui flows, we register the connection of the current flow
which is immediately picked up by the viewmodel. Another ui flow might
run and register a connection to be picked up by its viewmodel, and by
the time the first ui flow is done and tries to remove the iconnection
registration, that iconnection is not the one it registered any more. So
we're not removing registrations any more, and we just let the
UIController replace the IConnection any time it needs to launch a new
viewmodel.
We already support showing a separate dialog for authentication, but it
only worked when the selected ui flow was either authentication or the
clone/create flows, which reuse the same dialog window. It also worked
for publish, but that one is actually cheating by running two separate
ui flows (the auth and then the publish)

Since we now support long running ui flows that switch to subflows when
needed, we need to be able to show a view in either the pane or in the
dialog, basically popping up the dialog whenever needed and then
shutting it down without stopping the ui flow.
shana and others added 28 commits May 3, 2016
Fixes #282

We were getting into a state when loading the pane for the first time
where `Reload` would be called once as a result of the `RepoChanged`
call, which triggers when `Initialize(ServiceProvider)` runs, and then
`Reload` would run again as a result of the `Initialize(ViewWithData)`
call, because the Pull Requests button was clicked, which causes the
pane to reset itself. These two `Reload` calls would be executing
concurrently, causing a race condition that would crash randomly if the
controller was stopped and restarted at just the right point.

Need to make sure that nothing else can happen while
`Initialize(ServiceProvider)` is running, and that
`Initialize(ServiceProvider)` is run serially (no asyncs here!).
Polish Pull Request list view
[WIP] Add Pull Request Creation View
Replace hardcoded fontsizes with proportional text styles
Bump feature/pr/views version to latest alpha
Pull Request list view and viewmodel
@shana shana closed this Jul 4, 2017
@shana shana deleted the shana/testing-a-thing branch Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.