Add python 3.10#9034
Merged
Merged
Conversation
Collaborator
|
@busunkim96 Thank you for adding this Python 3.10 test coverage. LGTM if you can just fix the merge conflicts. We will need to push the Docker image but I can easily do that once this is merged. |
busunkim96
commented
Oct 14, 2021
Comment on lines
-290
to
-291
| "Programming Language :: Python :: 3.3", | ||
| "Programming Language :: Python :: 3.4", |
Contributor
Author
There was a problem hiding this comment.
@acozzette I removed 3.3 and 3.4 to match the python_requires>=3.5 below.
acozzette
reviewed
Oct 14, 2021
| } | ||
|
|
||
| build_python310_cpp() { | ||
| build_python_cpp_version py39-cpp |
Collaborator
There was a problem hiding this comment.
Should this say py310-cpp?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.10 release is scheduled for next Monday, 2021-10-04. https://www.python.org/dev/peps/pep-0619/
Because 3.10 is still technically a release candidate, the imagepython:3.10-busterdoes not yet exist, but should soon.python:3.10-buster now exists: https://hub.docker.com/_/python
Intended to be reviewed together with Kokoro config change in internal changelist 399739838.