Skip to content

all: upgrade to Mockito 2.28.2#6355

Merged
ran-su merged 1 commit into
grpc:masterfrom
suztomo:mockito
Oct 30, 2019
Merged

all: upgrade to Mockito 2.28.2#6355
ran-su merged 1 commit into
grpc:masterfrom
suztomo:mockito

Conversation

@suztomo

@suztomo suztomo commented Oct 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Mockito 2.28.2 is the latest in its 2.X versions.

Grep result for mockito in build.gradle:

There's no 2.25.1 any more:

suztomo@suxtomo24:~/grpc-java$ grep -ilr 2.25.1 ./
suztomo@suxtomo24:~/grpc-java$

Last mockito version upgrade d35fbd7 modified the 6 files.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 30, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA Check
The committers are authorized under a signed CLA.

@suztomo suztomo mentioned this pull request Oct 30, 2019
Closed
@ran-su

ran-su commented Oct 30, 2019

Copy link
Copy Markdown
Member

It looks like this PR is missing couple places that version number also need to be upgraded. You could check previous PRs for reference.

@suztomo

suztomo commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

Thank you for pointing that out. Let me check.

@suztomo

suztomo commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

@ran-su Updated the change. Does it look good now?

creamsoup
creamsoup approved these changes Oct 30, 2019
View reviewed changes

@creamsoup creamsoup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creamsoup creamsoup added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 30, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 30, 2019
@ran-su ran-su merged commit 3134df1 into grpc:master Oct 30, 2019
@ran-su

ran-su commented Oct 30, 2019

Copy link
Copy Markdown
Member

@suztomo Merged. Thank you.

@suztomo

suztomo commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

Thank you.

@suztomo suztomo deleted the mockito branch October 30, 2019 18:35
voidzcy pushed a commit to voidzcy/grpc-java that referenced this pull request Nov 3, 2019
@suztomo @voidzcy
all: upgrade to Mockito 2.28.2 (grpc#6355)
7219b21
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@creamsoup creamsoup creamsoup approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @ran-su @creamsoup @grpc-kokoro