Test and fix --exclude-config regression#341
Merged
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
sdeleuze
force-pushed
the
missing-exclude-config-repro
branch
2 times, most recently
from
8360029 to
ecb221b
Compare
Collaborator
Author
|
|
Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle and OfficialMetadataRepositoryFunctionalTest for Maven. See graalvmgh-340
sdeleuze
force-pushed
the
missing-exclude-config-repro
branch
from
ecb221b to
65777a7
Compare
sdeleuze
changed the title
--exclude-config works as expected--exclude-config regression
Collaborator
Author
|
@melix The regression was caused by a3b5f3f#diff-3ca19e7e49fe64feca3a1e88279c961b56e03450666583025c711da44cfb73bbL359-L370, this PR revert those changes. I have been able to validate it works both with NBT tests and with Spring AOT |
Collaborator
|
looks good to me. |
melix
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can now be checked by running
OfficialMetadataRepoFunctionalTestfor Gradleand
OfficialMetadataRepositoryFunctionalTestfor Maven.See gh-340