Skip to content

Add support x86_64-pc-windows-gnu#6110

Merged
lukastaegert merged 2 commits into
rollup:masterfrom
lsq:master
Sep 19, 2025
Merged

Add support x86_64-pc-windows-gnu#6110
lukastaegert merged 2 commits into
rollup:masterfrom
lsq:master

Conversation

@lsq

@lsq lsq commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Supports node built with gun toolschain in windows. I have already verified it by setting up a CI build on my fork github action.

@vercel

vercel Bot commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Sep 19, 2025 10:57am

@lsq lsq mentioned this pull request Sep 16, 2025
Closed
9 tasks
@lsq lsq changed the title Add support x86_64-pc-windows-gnu toolchain Add support x86_64-pc-windows-gnu Sep 16, 2025
lukastaegert
lukastaegert reviewed Sep 19, 2025
View reviewed changes

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking care. Just two questions.

Comment thread native.js Outdated
Comment thread .github/actions/custom-build/action.yaml Outdated
@codecov

codecov Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (1748736) to head (6c859d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6110   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10641    10641           
  Branches     2848     2848           
=======================================
  Hits        10507    10507           
  Misses         89       89           
  Partials       45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lsq

lsq commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

Hi, thanks for taking care. Just two questions.

Thank you for your suggestions. I have completed the modifications according to your suggestions. Please review them at your convenience.

@lukastaegert

lukastaegert commented Sep 19, 2025

Copy link
Copy Markdown
Member

There was a wrong path, I pushed a commit to fix this and triggered a beta release to try it out

@lukastaegert

lukastaegert commented Sep 19, 2025

Copy link
Copy Markdown
Member

You can try out rollup@4.51.1-0

@lsq

lsq commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

You can try out rollup@4.51.1-0
It works. @lukastaegert

image image

@lukastaegert lukastaegert added this pull request to the merge queue Sep 19, 2025
Merged via the queue into rollup:master with commit a0bb78c Sep 19, 2025
45 checks passed
@github-actions

github-actions Bot commented Sep 19, 2025

Copy link
Copy Markdown

This PR has been released as part of rollup@4.52.0. You can test it via npm install rollup.

This was referenced Sep 19, 2025
Closed
Closed
@ReenigneArcher ReenigneArcher mentioned this pull request Sep 20, 2025
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@lsq @lukastaegert