build: optimize pipeline take two#6078
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cyyynthia
changed the title
cyyynthia
force-pushed
the
opt-build-take-two
branch
from
70678ce to
902d7c4
Compare
cyyynthia
force-pushed
the
opt-build-take-two
branch
from
902d7c4 to
413ac99
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6078 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 271 271
Lines 10610 10610
Branches 2834 2834
=======================================
Hits 10482 10482
Misses 88 88
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
approved these changes
Aug 22, 2025
lukastaegert
left a comment
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Nice! I will see that I create a beta release first so that we can see if anything is broken.
Member
|
This is now published as rollup@4.48.0-0 |
Member
|
If nothing comes up, I will merge this on Monday. |
9 tasks
…ollup#6053)" This reverts commit 82a8f15.
Rust creates a dependency on glibc 2.34, whereas the napi binary only depends on glibc 2.14
lukastaegert
force-pushed
the
opt-build-take-two
branch
from
2177340 to
7ea9fbf
Compare
|
This PR has been released as part of rollup@4.48.1. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Apologies for breaking the builds earlier with #6053 😭 It seems I overlooked the fact that napi's tooling allows the final binary to not rely on flagship glibc versions, only requiring glibc 2.17 (2.14 in the final rollup binary) whereas the Rust-native cross build requires glibc 2.34... I was a bit too optimistic with Rust-native cross builds 😓
Hopefully this time I won't break things again... 🥲
Additionally, I set up the full test suite on aarch64 linux and windows, leveraging the new arm-native GHA runners.