Remove unnecessary hasShouldRevalidate condition for opting out#15012
Merged
Conversation
aeb65ce to
b0bc444
Compare
b0bc444 to
49cbdd2
Compare
Contributor
|
Nice catch! Thanks for the fix 👍 |
brophdawg11
approved these changes
May 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when
unstable_defaultShouldRevalidate={false}is used and a matched route does not export ashouldRevalidatefunction. The current code skips counting the route as a route to opt out when determining when to set the_routesquery param.I wrote a test with 3 routes, all with their own loaders and no
shouldRevalidatefunctions.When on the
/parentroute, i'm clicking a link withunstable_defaultShouldRevalidate={false}to navigate to/parent/a. This should trigger a data call for onlyapp/parent.a.tsx's loader. However, the data call that's executed does not have the_routesquery param, so all loaders are revalidated.This PR makes it so that the data call is only to fetch
app/parent.a.tsx's loader data.