✨ Add new custom-cache-suffix option#239
Merged
ramsey merged 1 commit intoNov 4, 2022
Merged
Conversation
ramsey
approved these changes
Nov 3, 2022
| # via the first workflow which is run every Monday. | ||
| - uses: "ramsey/composer-install@v2" | ||
| with: | ||
| custom-cache-suffix: $(/bin/date -u --date='last Mon' "+%F") |
Owner
|
Something about the cache_key_08.exp test is causing a failure, but I can't tell what it is yet. |
As discussed in 234. Includes tests. Fixes 234
jrfnl
force-pushed
the
feature/234-add-new-custom-cache-extra-key
branch
from
d2954eb to
6f57711
Compare
Contributor
Author
Windows and file permissions. Should be fixed now. |
Contributor
Author
|
Hmm.. Composer v1 still giving trouble... |
Contributor
Author
|
(which is weird as I had a passing build before I tidied up and rebased) |
Contributor
Author
|
@ramsey As by now it's not the new test which is failing, could you restart the build just to check it wasn't some Composer hick-up ? |
Owner
|
Re-running |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #239 +/- ##
==========================================
+ Coverage 97.45% 97.47% +0.02%
==========================================
Files 5 5
Lines 118 119 +1
==========================================
+ Hits 115 116 +1
Misses 3 3
|
Contributor
Author
|
Right first round done: applied this in some 40 repos ;-) For anyone looking for some more date-based example code: - name: Install Composer dependencies
uses: ramsey/composer-install@v2
with:
# Bust the cache at least once every three months - output format: YYYYqQ, example: 2022q4.
custom-cache-suffix: $(/bin/date +%Y)q$(( ($(/bin/date +%-m)-1)/3+1 ))
- name: Install Composer dependencies
uses: ramsey/composer-install@v2
with:
# Bust the cache at least once a month - output format: YYYY-MM-DD.
custom-cache-suffix: $(date -u -d "-0 month -$(($(date +%d)-1)) days" "+%F")
- name: Install Composer dependencies
uses: ramsey/composer-install@v2
with:
# Bust the cache at least once a week - output format: YYYY-MM-DD.
custom-cache-suffix: $(/bin/date -u --date='last Mon' "+%F") |
Contributor
Author
|
Simplified version of the "once a month" code sample: - name: Install Composer dependencies
uses: ramsey/composer-install@v2
with:
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #234.
This adds a new
custom-cache-suffixoption to the action which allows for adding a custom addition to the cache key, which can be helpful to break out of outdated caches, especially when a project does not have a committedcomposer.lockfile.Fixes #234
Motivation and context
See #234
How has this been tested?
Both unit tests as well as integration tests are included with the PR.
Types of changes
PR checklist