Fixed rollback of extra_data migration#626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 39 40 +1
Lines 1172 1185 +13
Branches 144 77 -67
=======================================
+ Hits 1075 1087 +12
- Misses 72 73 +1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Merged, thanks for your contribution! |
|
@niklas-scholz & @nijel Hi!
I suspect that PyPI still hosts an older version without these changes. Thanks in advance! |
|
Yes, we should release soon. @gersona is now going through issues, and we will get eventually to releasing. |
3 participants
Proposed changes
The
extra_datajson field migration0013_migrate_extra_data.pywas not revertable since theis_text_fieldtype check was throwing a TypeError since the first argument is an instance instead of a class. This error occurs only when reverting migrations on databases other than SQLite.Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.