feat: add assert.match helper#53
Merged
Merged
Conversation
kraenhansen
previously requested changes
Apr 25, 2026
Member
kraenhansen
left a comment
kraenhansen
left a comment
There was a problem hiding this comment.
Let's add a harness test for it as well 👍
Draft
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
legendecas
approved these changes
Apr 27, 2026
Member
|
@kraenhansen would you mind taking a look again? The harness test has been added. Thanks! |
Member
|
I'll merge this on Monday if no further concerns raised. |
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used in test_exception and test_finalizer