Skip to content

src: use C++14 deprecated attribute for NODE_DEPRECATED #63755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 7, 2026
+1 −9
Merged

src: use C++14 deprecated attribute for NODE_DEPRECATED #63755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df4f85f
src: use C++14 deprecated attribute for `NODE_DEPRECATED`
addaleax Jun 5, 2026
bf3803b
fixup! src: use C++14 deprecated attribute for `NODE_DEPRECATED`
addaleax Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use C++14 deprecated attribute for NODE_DEPRECATED 
This has been standardized for a while, so there's no real
reason not to just use it over compiler-specific alternatives.

Signed-off-by: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@addaleax
addaleax committed Jun 5, 2026
commit df4f85fb890fb864cb635835231ebe5cd0ca4cdb
10 changes: 1 addition & 9 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
# define NODE_DEPRECATED(message, declarator) declarator
#else // NODE_WANT_INTERNALS
# if NODE_CLANG_AT_LEAST(2, 9, 0) || NODE_GNUC_AT_LEAST(4, 5, 0)
# define NODE_DEPRECATED(message, declarator) \
__attribute__((deprecated(message))) declarator
# elif defined(_MSC_VER)
# define NODE_DEPRECATED(message, declarator) \
__declspec(deprecated) declarator
# else
# define NODE_DEPRECATED(message, declarator) declarator
# endif
# define NODE_DEPRECATED(message, declarator) [[deprecated(message)]] declarator
#endif

// Forward-declare libuv loop
Expand Down
Loading