Allow constructing a RedisStore from a RedisPool#122
Merged
Conversation
Makes `RedisStore` generic over any type that implements fred's `KeysInterface` so either a `RedisClient` or `RedisPool` can be used. Since `RedisPool` is generally preferred for most applications, I switched all examples and documentation to use `RedisPool`. But, existing code that used `RedisClient` will not fail to compile. I also modified the integration test that tests `RedisStore` to use a `RedisPool`. Fixes issue #92
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 76.35% 75.89% -0.46%
==========================================
Files 12 12
Lines 499 502 +3
==========================================
Hits 381 381
- Misses 118 121 +3 ☔ View full report in Codecov by Sentry. |
Owner
|
Lovely! Thank you for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
RedisStoregeneric over any type that implements fred'sKeysInterfaceso either aRedisClientorRedisPoolcan be used.Since
RedisPoolis generally preferred for most applications, I switched all examples and documentation to useRedisPool. But, existing code that usedRedisClientwill not fail to compile.I also modified the integration test that tests
RedisStoreto use aRedisPool.Fixes issue #92