FIX: axhline() / axvline() now always do autoscaling#31596
Draft
timhoffm wants to merge 1 commit into
Draft
Conversation
timhoffm
force-pushed
the
fix-axvline-autoscale
branch
from
f072289 to
48f8235
Compare
Member
Author
|
This breaks some tests, in particular widgets. We likely need to exclude the lines there from autoscaling. |
Closes matplotlib#14651. As they are regularly added wih `add_line()`, they were always added to the data limits, but autoscaling was only updated under certain conditions, which led to an inconsistent state. See matplotlib#14651 (comment) Because of the inconsistent state, I'll classify this as a bug fix and justify that change can happen immediately without a deprecation.
timhoffm
force-pushed
the
fix-axvline-autoscale
branch
from
48f8235 to
c52a12c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14651.
As they are regularly added wih
add_line(), they were always added to the data limits, but autoscaling was only updated under certain conditions, which led to an inconsistent state. See #14651 (comment)Because of the inconsistent state, I'll classify this as a bug fix and justify that change can happen immediately without a deprecation.