actions: publish should occur after successful run#4218
Merged
Conversation
Signed-off-by: mickael emirkanian <mickael.emirkanian@docker.com>
Contributor
|
cc @djs55 |
deitch
approved these changes
Jun 3, 2026
Collaborator
deitch
left a comment
deitch
left a comment
There was a problem hiding this comment.
LGTM. Nice catch on the missing conditions
Collaborator
|
I know the parts that CI is testing are unaffected by this, but let us be good citizens and wait the extra 15-20 mins for CI to go all green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Updates the publish action to run only if the build is successful