feat(clickhouse_driver): Support span streaming#6508
Open
alexander-alderman-webb wants to merge 4 commits into
Open
feat(clickhouse_driver): Support span streaming#6508alexander-alderman-webb wants to merge 4 commits into
alexander-alderman-webb wants to merge 4 commits into
Conversation
Contributor
Codecov Results 📊✅ 88555 passed | ⏭️ 6025 skipped | Total: 94580 | Pass Rate: 93.63% | Execution Time: 299m 17s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 91.43%. Project has 2486 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.34% 89.34% —%
==========================================
Files 192 192 —
Lines 23302 23321 +19
Branches 8010 8022 +12
==========================================
+ Hits 20819 20835 +16
- Misses 2483 2486 +3
- Partials 1312 1314 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the streaming path, use
db.namespaceinstead ofdb.namedb.system.nameinstead ofdb.systemDropped attributes:
db.paramsdb.resultquerydb.query_idTests for adding breadcrumbs based on spans have not been parametrized as breadcrumbs are not automatically created from spans with the new streaming lifecycle.
Adapting Tests
sed commands used for converting transaction context managers:
sed commands used for converting event capture:
sed commands used for converting
op:sed commands used for converting origin:
sed commands used for converting description:
sed -i '' 's/"description"/"name"/g'
sed commands used for converting data to attributes:
sed commands used for converting timestamps:
other test changes:
Issues
Closes #6011
Reminders
uv run ruff.feat:,fix:,ref:,meta:)