Modified greater than uint32 bits data test#53
Merged
Conversation
dcousens
reviewed
Jan 22, 2018
| var _hash = crypto.createHash('sha1') | ||
| var hash = new Sha1() | ||
| var bigData = Buffer.alloc(Math.pow(2, 32) / 8) | ||
| var bigData = Buffer.alloc((Math.pow(2, 32) + Math.pow(2,31))/ 8) |
Member
There was a problem hiding this comment.
Can this actually be changed to 0xffffffff and 0x7fffffff ?
Contributor
Author
There was a problem hiding this comment.
That would make 32nd bit as 0. Have changed it to 0x1ffffffff
Member
|
Published as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains test related to PR #51