Bump ASM 9.8 to support JDK 25 bytecode#744
Conversation
The current ASM 9.7 does not support JDK 24 and 25 bytecode. ``` ... [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.0:shade (default) on project kyuubi-spark-sql-engine_2.12: Error creating shaded jar: Problem shading JAR /Users/chengpan/.m2/repository/net/bytebuddy/byte-buddy/1.17.6/byte-buddy-1.17.6.jar entry META-INF/versions/24/net/bytebuddy/jar/asmjdkbridge/JdkClassWriter$1.class: java.lang.IllegalArgumentException: Unsupported class file major version 68 -> [Help 1] ... ```
|
the failed UT does not look related to this change, can any committer review this PR? |
|
jdk25 release is next week, but not sure this change was pushed to a new release of the plugin... |
looks not. I will have a look to cut release. |
|
@pan3793 @olamy Just to be clear, is version 3.6.1 compatible with JDK 25 or just 24? Because I get this error for a JDK 25 project-build:
If not, how would one "override the asm dependency in your pom" to work with JDK 25? |
|
@InsertPikachuFace I'm not much familiar with this plugin, below answers are based on my understanding.
It should support JDK 25.
Apache Kyuubi resolved the issue via apache/kyuubi#7164 |
|
I retried it with and without the asm override and nothing changed. |
|
the problem here is not maven-shade-plugin but minimizer library which is bundling/shading asm. |
The current ASM 9.7 does not support JDK 24 and 25 bytecode.