Skip to content

Bump ASM 9.8 to support JDK 25 bytecode#744

Merged
olamy merged 1 commit into
apache:masterfrom
pan3793:patch-1
Aug 7, 2025
Merged

Bump ASM 9.8 to support JDK 25 bytecode#744
olamy merged 1 commit into
apache:masterfrom
pan3793:patch-1

Conversation

@pan3793

@pan3793 pan3793 commented Aug 7, 2025

Copy link
Copy Markdown
Member

The current ASM 9.7 does not support JDK 24 and 25 bytecode.

...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.0:shade (default) on project kyuubi-spark-sql-engine_2.12: Error creating shaded jar: Problem shading JAR /Users/chengpan/.m2/repository/net/bytebuddy/byte-buddy/1.17.6/byte-buddy-1.17.6.jar entry META-INF/versions/24/net/bytebuddy/jar/asmjdkbridge/JdkClassWriter$1.class: java.lang.IllegalArgumentException: Unsupported class file major version 68 -> [Help 1]
...

The current ASM 9.7 does not support JDK 24 and 25 bytecode.

```
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.0:shade (default) on project kyuubi-spark-sql-engine_2.12: Error creating shaded jar: Problem shading JAR /Users/chengpan/.m2/repository/net/bytebuddy/byte-buddy/1.17.6/byte-buddy-1.17.6.jar entry META-INF/versions/24/net/bytebuddy/jar/asmjdkbridge/JdkClassWriter$1.class: java.lang.IllegalArgumentException: Unsupported class file major version 68 -> [Help 1]
...
```
@pan3793

pan3793 commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

the failed UT does not look related to this change, can any committer review this PR?

@olamy olamy added the dependencies Pull requests that update a dependency file label Aug 7, 2025
@olamy olamy self-assigned this Aug 7, 2025
@olamy olamy merged commit d008516 into apache:master Aug 7, 2025
36 of 40 checks passed
@github-actions github-actions Bot added this to the 3.6.1 milestone Aug 7, 2025
@ludoch

ludoch commented Sep 8, 2025

Copy link
Copy Markdown

jdk25 release is next week, but not sure this change was pushed to a new release of the plugin...

@olamy

olamy commented Sep 8, 2025

Copy link
Copy Markdown
Member

jdk25 release is next week, but not sure this change was pushed to a new release of the plugin...

looks not. I will have a look to cut release.
Even if it's still possible to override the asm dependency in your pom, I agree it's not really convenient.

@InsertPikachuFace

Copy link
Copy Markdown

@pan3793 @olamy Just to be clear, is version 3.6.1 compatible with JDK 25 or just 24? Because I get this error for a JDK 25 project-build:

Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.1:shade (default) on project kfz-fahrzeugsuche-service: Error creating shaded jar: Unsupported class file major version 69

If not, how would one "override the asm dependency in your pom" to work with JDK 25?

@pan3793

pan3793 commented Oct 17, 2025

Copy link
Copy Markdown
Member Author

@InsertPikachuFace I'm not much familiar with this plugin, below answers are based on my understanding.

is version 3.6.1 compatible with JDK 25 or just 24?

It should support JDK 25.

how would one "override the asm dependency in your pom" to work with JDK 25?

Apache Kyuubi resolved the issue via apache/kyuubi#7164

@InsertPikachuFace

Copy link
Copy Markdown

I retried it with and without the asm override and nothing changed.
But when I removed the minimizeJar configuration it completed immediately, even with the default asm dependencies. Weird.

@olamy

olamy commented Oct 20, 2025

Copy link
Copy Markdown
Member

the problem here is not maven-shade-plugin but minimizer library which is bundling/shading asm.
see #747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants