feat: Add PHP extensions handling.#12
Conversation
boring-cyborg
Bot
added
Dependencies 📦
|
@drupol Thanks for filing, loving the suggestion. But could you add the list of extensions as output to the CI workflow? https://github.com/WyriHaximus/github-action-composer-php-versions-in-range/blob/main/.github/workflows/ci.yml |
I'm afraid I have no idea how to do that :( Feel free to commit in this PR if you want. |
Want me to guide you through that in this PR? |
|
Of course, all the help is welcome. |
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
The code all looks good, however, there are two things missing. Most importantly an example in the readme on how to use this in a workflow.
Secondly, it's missing showing this output in the CI. My suggestion would be to add the outputs you added to this list: https://github.com/WyriHaximus/github-action-composer-php-versions-in-range/blob/main/.github/workflows/ci.yml#L16-L19
Secondly to show that, add the following at the end of the file:
extensions:
name: Detected extensions on ${{ matrix.os }}
strategy:
matrix:
os:
- ubuntu-latest
- windows-latest
- macos-latest
needs:
- get-supported-php-versions
runs-on: ${{ matrix.os }}
steps:
- run: |
echo "All require extensions: ${{ needs.get-supported-php-versions.outputs.extensions }}"
echo "Require extensions: ${{ needs.get-supported-php-versions.outputs.requiredExtensions }}"
echo "Dev require extensions: ${{ needs.get-supported-php-versions.outputs.requiredDevExtensions }}"
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍!
Take your time for the readme updates, I'll merge and tag this as is. And once you have worked out a real-world example, feel free to open a PR for the readme.
|
Just released |
2 participants
Hi,
Here's a small feature I just added that would be useful for me.
Basically, it infers PHP
extensionsfromcomposer.json.Let me know what you think.