blender/blender
277
979
Fork 1.6k
Code Issues 6.8k Pull Requests 1.9k Actions Packages Projects 24 Wiki Activity

Fix #118769: Remove parent parameter from new_panel function #118792

Merged
Lukas Tönne merged 2 commits from LukasTonne/blender:purge-panel-parent-parameter into main 2024-02-27 13:30:23 +01:00
Conversation 4 Commits 2 Files Changed 2
+8 -33
Lukas Tönne commented 2024-02-27 11:29:31 +01:00
Member
Copy Link
Copy Source

Nested panels are not supported currently, and this parameter serves no
actual purposes. Only the root panel supports adding child panels and it
is not user-accessible (adding the root panel is done using a nullptr
for the parent).

Nested panels are not supported currently, and this parameter serves no actual purposes. Only the root panel supports adding child panels and it is not user-accessible (adding the root panel is done using a nullptr for the parent).
Lukas Tönne added 1 commit 2024-02-27 11:29:37 +01:00
Nodes: Remove parent parameter from the new_panel function.
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
697116bac4 
Nested panels are not supported currently, and this parameter serves no
actual purposes. Only the root panel supports adding child panels and it
is not user-accessible (adding the root panel is done using a nullptr
for the parent).
Lukas Tönne requested review from Brecht Van Lommel 2024-02-27 11:29:48 +01:00
Lukas Tönne added this to the Module: Nodes & Physics project 2024-02-27 11:29:56 +01:00
Lukas Tönne commented 2024-02-27 11:30:45 +01:00
Author
Member
Copy Link
Copy Source

This would be a breaking change.

This would be a breaking change.
Brecht Van Lommel approved these changes 2024-02-27 11:43:08 +01:00
Lukas Tönne commented 2024-02-27 12:08:42 +01:00
Author
Member
Copy Link
Copy Source

@blender-bot build

@blender-bot build
Lukas Tönne added 1 commit 2024-02-27 12:40:49 +01:00
Removed broken test case, this is no longer supported by the API.
buildbot/vexp-code-patch-lint Build done.
Details
buildbot/vexp-code-patch-linux-x86_64 Build done.
Details
buildbot/vexp-code-patch-darwin-arm64 Build done.
Details
buildbot/vexp-code-patch-darwin-x86_64 Build done.
Details
buildbot/vexp-code-patch-windows-amd64 Build done.
Details
buildbot/vexp-code-patch-coordinator Build done.
Details
a5fda1f0b2
Lukas Tönne commented 2024-02-27 12:41:02 +01:00
Author
Member
Copy Link
Copy Source

@blender-bot build

@blender-bot build
Lukas Tönne merged commit b1636bc781 into main 2024-02-27 13:30:23 +01:00
Lukas Tönne deleted branch purge-panel-parent-parameter 2024-02-27 13:30:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Brecht Van Lommel
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositor
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Design
Design topics on a product level.
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Human Interface Guidelines
Tasks related to Blender's Human Interface Guidelines: https://developer.blender.org/docs/features/interface/human_interface_guidelines/
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Lab
Projects related to Blender Lab, the innovation space within Blender.
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
OpenPBR
Topics related to the OpenPBR integration/support in Blender
Interest
Outliner
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good Example
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
iOS
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Module: Nodes & Physics
Assignees
Clear assignees
Blendify (Aaron Carlisle) Alaska (Alaska) angavrilov (Alexander Gavrilov) frogstomp (Aleš Jelovčan) amelief (Amélie Fondevilla) eyecandy (Andy Goralczyk) ankitm (Ankit Meel) Anthony-Roberts (Anthony Roberts) aras_p (Aras Pranckevicius) bartvdbraak (Bart van der Braak) mont29 (Bastien Montagne) blender-bot (Blender Bot) bnagirniak (Bogdan Nagirniak) BClark (Brad Clark) brecht (Brecht Van Lommel) BrianSavery (Brian Savery (AMD)) ideasman42 (Campbell Barton) casey-bianco-davis (Casey Bianco-Davis) CharlesWardlaw (Charles Wardlaw) CharlieJolly (Charlie Jolly) lateasusual (Chris Clyne (Lateasusual)) ChrisLend (Christoph Lendenfeld) chrismile (Christoph Neuhauser) fclem (Clément Foucault) darknation (Colin Basnett) Kdaf (Colin Marmond) dfelinto (Dalai Felinto) pioverfour (Damien Picard) DanielBystedt (Daniel Bystedt) pepe-school-land (Daniel Martinez Lara ) zanqdo (Daniel Salazar) Mets (Demeter Dzadik) EAW (Evan Wilson) filedescriptor (Falk David) fsiddi (Francesco Siddi) DagerD (Georgiy Markelov) guishe (Guillermo Venegas) zazizizou (Habib Gahbiche) HooglyBoogly (Hans Goudey) Harley (Harley Acheson) Hjalti (Hjalti Hjálmarsson) Hoshinova (Hoshinova) howardt (Howard Trickey) mod_moder (Iliya Katushenock) JacquesLucke (Jacques Lucke) James-McCarthy-4 (James McCarthy) Jason-Fielder (Jason Fielder) JasonSchleifer (Jason schleifer) Jeroen-Bakker (Jeroen Bakker) deadpin (Jesse Yurkovich) neXyon (Joerg Mueller) eliphaz (John Kiril Swenson) guitargeek (Johnny Matthews) Brainzman (Jonas Holzman) JoniMercado (Jonatan Mercado) Bone-Studio (Juan Gea) jpbouza-4 (Juan Pablo Bouza) JulianEisel (Julian Eisel) JulienDuroure (Julien Duroure) JulienKaspar (Julien Kaspar) kevindietrich (Kévin Dietrich) lone_noel (Leon Schittek) lucianomunoz (Luciano Muñoz Sessarego) LukasStockner (Lukas Stockner) LukasTonne (Lukas Tönne) LunaRood (Luna Rood) EosFoxx (Marion Stalke) not_mark (Mark van de Ruit) Baardaap (Martijn Versteegh) mendio (Matias Mendiola) Matt-McLin (Matt McLin) MetinSeven (Metin Seven) wave (Michael B Johnson) Michael-Jones (Michael Jones (Apple)) makowalski (Michael Kowalski) pragma37 (Miguel Pozo) Natalie-Rozvezeva (Natalie Rozvezeva) nrupsis (Nate Rupsis) nathanvegdahl (Nathan Vegdahl) PrototypeNM1 (Nicholas Rishel) TinyNick (Nick Alberelli) nickberckley (Nika Kutsniashvili) Sirgienko (Nikita Sirgienko) OmarEmaraDev (Omar Emara) pablovazquez (Pablo Vazquez) PaoloAcampora (Paolo Acampora) pmoursnv (Patrick Mours) muxed-reality (Peter Kim) lichtwerk (Philipp Oeser) P2design (Pierrick PICAUT) PratikPB2123 (Pratik Borhade) Limarest (Ramil Roosileht) farsthary (Raul Fernandez Hernandez) LazyDodo (Ray molenkamp) iss (Richard Antalik) salipour (Sahar A. Kashi) Sayak-Biswas (Sayak Biswas) Sean-Kim (Sean Kim) sherholz (Sebastian Herholz) sebastian_k (Sebastian Koenig) ZedDB (Sebastian Parborg) semtip (Sem Tip) Sergey (Sergey Sharybin) IRIEShinsuke (Shinsuke Irie) SietseB (Sietse Brouwer) SimonThommes (Simon Thommes) SonnyCampbell_Unity (Sonny Campbell) staging-bot (Staging Bot) Stefan_Werner (Stefan Werner) dr.sybren (Sybren A. Stüvel) Tariq-Sulley (Tariq Sulley) ThomasDinges (Thomas Dinges) triager-bot (Triager Bot) uatest-bot (UATEST Bot) BassamKurdali (Ursula kurdali) Vasyl-Pidhirskyi (Vasyl Pidhirskyi) Vivikowski (Vivien Lulkowski) WannesMalfait (Wannes Malfait) weizhen (Weizhen Huang) xavierh-intel (Xavier Hallade) jenkm (Yevgeny Makarov) ChengduLittleA (YimingWu) gfxcoder (jon denning) quackarooni (quackarooni)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#118792
Delete Branch "LukasTonne/blender:purge-panel-parent-parameter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?