In T368271#10349192, @Lucas_Werkmeister_WMDE wrote:

Given that the test was explicitly motivated by code coverage (Gerrit change, CC @thiemowmde), I’m inclined to say that most likely nothing actually relies on how exactly this library handles invalid UTF-8 input. So it might be better to leave the code unchanged and drop the test – the behavior for U+110000 et al. would then just be unspecified (“garbage in, garbage out”). But I’ll see how I feel about it next week ^^

Nov 27 2024, 11:30 AM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

gerritbot added a project to T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI: Patch-For-Review.

Nov 27 2024, 11:30 AM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

gerritbot added a comment to T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI.

Change #1098485 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[purtle@master] Remove test for “U+110000 and above”

https://gerrit.wikimedia.org/r/1098485

Nov 27 2024, 11:30 AM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

Nov 25 2024

karapayneWMDE moved T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Nov 25 2024, 9:18 AM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

Nov 22 2024

• Lucas_Werkmeister_WMDE updated subscribers of T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI.

Well, the following works, though I don’t like it very much:

Nov 22 2024, 5:12 PM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

Maintenance_bot moved T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.

Nov 22 2024, 4:29 PM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

• Lucas_Werkmeister_WMDE added a comment to T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI.

In T368271#10348908, @Lucas_Werkmeister_WMDE wrote:

And the good news is: while this may not be valid UTF-8, PHP’s interpretation of "\xF8\x84\x90\x80\x80", according to 3v4l, seems to have been stable since PHP 5.4. So let’s change the test to that, then.

Nov 22 2024, 4:24 PM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

• Lucas_Werkmeister_WMDE claimed T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI.

I’m confused by this test, actually. It’s called “ignore U+110000 and above”, but that doesn’t seem to match the test string very well. The hexadecimal input corresponds to:

Nov 22 2024, 3:57 PM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle

• Lucas_Werkmeister_WMDE added a comment to T368271: [SW][REPO] Fix purtle so that its tests pass in PHP 8.3, and enable in CI.

Nov 22 2024, 3:56 PM · [Archived]Wikidata Dev Team (Wikidata.org Slice), Wikidata, User-ItamarWMDE, wmde-wikidata-tech, PHP 8.3 support, Purtle