Change #1164233 merged by jenkins-bot:

[integration/config@master] Move VipsScaler to other

https://gerrit.wikimedia.org/r/1164233

Change #1164233 had a related patch set uploaded (by Arlolra; author: Arlolra):

[integration/config@master] Move VipsScaler to other

https://gerrit.wikimedia.org/r/1164233

The special page was disabled in,
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VipsScaler/+/722385

Thank you!

Stop branching VipsScaler for Wikimedia production

Mentioned in SAL (#wikimedia-operations) [2025-06-25T20:51:25Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1159599|Undeploy VipsScaler (T290759)]] (duration: 47m 37s)

arlolra opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/185

Mentioned in SAL (#wikimedia-operations) [2025-06-25T20:34:41Z] <arlolra@deploy1003> arlolra: Backport for [[gerrit:1159599|Undeploy VipsScaler (T290759)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-06-25T20:03:47Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1159599|Undeploy VipsScaler (T290759)]]

Change #1159599 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy VipsScaler

https://gerrit.wikimedia.org/r/1159599

Change #1159599 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Undeploy VipsScaler

https://gerrit.wikimedia.org/r/1159599

In T290759#10920394, we disabled VipScaler in group2, so I'm cautiously going to consider this done.

Mentioned in SAL (#wikimedia-operations) [2025-06-16T20:19:54Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1156515|Disable VipsScaler in group2 (T290759)]] (duration: 09m 53s)

Mentioned in SAL (#wikimedia-operations) [2025-06-16T20:11:59Z] <arlolra@deploy1003> arlolra: Backport for [[gerrit:1156515|Disable VipsScaler in group2 (T290759)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-06-16T20:10:01Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1156515|Disable VipsScaler in group2 (T290759)]]

Change #1156515 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable VipsScaler in group2

https://gerrit.wikimedia.org/r/1156515

Change #1156515 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Disable VipsScaler in group2

https://gerrit.wikimedia.org/r/1156515

Thank you!!!

Mentioned in SAL (#wikimedia-operations) [2025-06-09T20:14:20Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1154128|Disable VipsScaler in group1 (T290759)]] (duration: 10m 23s)

Mentioned in SAL (#wikimedia-operations) [2025-06-09T20:05:56Z] <arlolra@deploy1003> arlolra: Backport for [[gerrit:1154128|Disable VipsScaler in group1 (T290759)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-06-09T20:03:57Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1154128|Disable VipsScaler in group1 (T290759)]]

Change #1154128 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable VipsScaler in group1

https://gerrit.wikimedia.org/r/1154128

I'm not sure how meaningful this is but I downloaded sampling trace logs from https://performance.wikimedia.org/arclamp/logs/daily/ and got

In T290759#10889680, @ABreault-WMF wrote:

In T290759#10889494, @Ladsgroup wrote:

Maybe it's fixed via different route. If you think so (T291014#7578524) then let's go ahead.

Yeah, without the VipsScaler hook, isImageAreaOkForThumbnaling should return early, based on the value in production.

But from T290759#10889091, we shouldn't really be in TransformationalImageHandler::doTransform to begin with. If we are, the production value is set based on Thumbor and we're about to do local scaling, which doesn't seem right.

In T290759#10889494, @Ladsgroup wrote:

Maybe it's fixed via different route. If you think so (T291014#7578524) then let's go ahead.

In T290759#10889114, @ABreault-WMF wrote:

In T290759#9886432, @Ladsgroup wrote:

I played with it and it's waaay more complicated than it looks. So I much that I gave up. If someone is willing to work on it, I'd be happy to help.

Is there anything you remember seeing that was giving you pause? Otherwise, I think it might be worth trying to proceed to group1.

Change #1154128 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Disable VipsScaler in group1

https://gerrit.wikimedia.org/r/1154128

In T290759#9886432, @Ladsgroup wrote:

I played with it and it's waaay more complicated than it looks. So I much that I gave up. If someone is willing to work on it, I'd be happy to help.

In T290759#10613659, @Jdforrester-WMF wrote:

We should definitely do T291014 and then this, but I'm not doing it right now.

In T291014#7364592, @Legoktm wrote:

There are two hooks in this extension that we've learned the hard way still have some impact.

The other hook is BitmapHandlerTransform, it clearly does something based on T290973: Error: Call to a member function getMimeType() on null, however I don't actually understand how this actually overrides anything because per exec.log, it's not actually shelling out to vips.

In T326915#10849812, @cscott wrote:

I believe the current plan is to try to undeploy T290759: Undeploy VipsScaler from Wikimedia wikis because /in theory/ some other changes in core have made it easier to do this?
See
https://wikis.world/@anticomposite/114489679162565721

@Jdforrester-WMF CTT would like to help with this.

I believe the current plan is to try to undeploy T290759: Undeploy VipsScaler from Wikimedia wikis because /in theory/ some other changes in core have made it easier to do this?
See
https://wikis.world/@anticomposite/114489679162565721

@MSantos can you check, please?

We should definitely do T291014 and then this, but I'm not doing it right now.

In T326915#10604576, @A_smart_kitten wrote:

Came across this task while going through the revision history of Developers/Maintainers -- just noting that this task is currently under the "Update unowned extensions" column of Temporary accounts, but VipsScaler was added to Developers/Maintainers in October 2024 with the information that MediaWiki-Engineering/Content-Transform-Team stewards this extension.

Thanks for the information! I've tagged this task with that team for their attention.