Change #1281992 merged by jenkins-bot:

[mediawiki/core@master] UploadVerification: Convert remaining wfShell* commands to Shell class

https://gerrit.wikimedia.org/r/1281992

This actually seems to be only partially problematic. In https://meta.wikimedia.beta.wmcloud.org/wiki/Special:Interwiki today, wikt points to https://en.wiktionary.beta.wmcloud.org/wiki/$1 as expected. It seems to be the case that all of the short codes point at some *.beta.wmcloud.org host. The prefixes that point out to production are the full project names like wiktionary, wikipedia, wikisource, etc.

Projects are populated via SchemaHookHandlers::onLoadExtensionSchemaUpdates so we don't need to do this.

Change #1304567 abandoned by Aude:

[mediawiki/extensions/WikimediaMaintenance@master] Add ReadingLists project step to addWiki.php

https://gerrit.wikimedia.org/r/1304567

Change #1304600 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaMaintenance] Add ReadingLists dependency

https://gerrit.wikimedia.org/r/1304600

Change #1304600 had a related patch set uploaded (by Aude; author: Aude):

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaMaintenance] Add ReadingLists phan dependency

https://gerrit.wikimedia.org/r/1304600

Change #1304567 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/WikimediaMaintenance@master] Add ReadingLists project step to addWiki.php

https://gerrit.wikimedia.org/r/1304567

Change #1303334 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] Emit warnings for deprecated Shell global functions

https://gerrit.wikimedia.org/r/1303334

Another possible action item here: include the DB server where the creation happened in the output. While this wouldn't prevent the issue from happening, it would allow me to double check it got created at the expected place.

This is probably closer to our Rdbms lib than to WikimediaMaintenance.

In T429302#12022853, @Urbanecm_WMF wrote:

• Declare virtual domains unconditionally: move $wgVirtualDomainsMapping declarations in CommonSettings.php outside of their respective $wmgUseXxx blocks

In T429302#12022853, @Urbanecm_WMF wrote:

I'm also curious why $lbf->getLoadBalancer( $virtualDomain ) with an unrecognized $virtualDomain returns a pointer to s3. I would expect the main section (or an error), but definitely not s3...

The accidental creation of wikidatawiki at s3 makes me think... Should the script even attempt to run CREATE DATABASE IF NOT EXISTS? I can't think of a scenario where an x1 database wouldn't already exist... addWiki.php should handle provisioning it.

This is how I located them:

Interestingly, the script (somehow) decided to create the wikidatawiki tables on s3 wikidatawiki, not on s8 wikidatawiki (as I would expect when virtualdomain points nowhere):

I ended up having to run the maintenance script within mw-debug (where the virtual domain was already defined), and then proceed.

Change #1301407 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] ServiceWiring: Convert GlobalIdGenerator to Shell class

https://gerrit.wikimedia.org/r/1301407

Change #1301406 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] cleanupSpam: Convert to Shell class call

https://gerrit.wikimedia.org/r/1301406

I'm not sure taking SecurePoll maintenance scripts out of the SecurePoll repo is the best way to organize things. Would need some convincing.

Many of these can be deleted following T423547.

Should now be patches for review against all WMF-deployed code & core per codesearch.

Change #1285863 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] GlobalIdGenerator: Convert deprecated shell global functions calls to Shell class

https://gerrit.wikimedia.org/r/1285863

Change #1281992 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] UploadVerification: Convert remaining wfShell* commands to Shell class

https://gerrit.wikimedia.org/r/1281992

Parent task was closed and https://abstract.wikipedia.org/wiki/Special:ManageMessageGroupSubscriptions works for me now.

Change #1269539 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/TimedMediaHandler@master] [UNTESTED] Replace deprecated global shell functions

https://gerrit.wikimedia.org/r/1269539

Change #1264322 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace usages of Shell related globals

https://gerrit.wikimedia.org/r/1264322

Change #1264322 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/Scribunto@master] Replace usages of Shell related globals

https://gerrit.wikimedia.org/r/1264322

Change #1266157 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Handle virtual domains for Translate

https://gerrit.wikimedia.org/r/1266157

Removing MediaWiki-extensions-Translate as this is solely about WMF production stuff.