Page MenuHomePhabricator

Update tools belt to accommodate watch and bookmark and update page tools to only show icons at lower resolutions
Closed, ResolvedPublic3 Estimated Story Points

Assigned To
Authored By
Jdlrobson-WMF
May 12 2026, 10:57 PM
Referenced Files
F90186447: Screenshot 2026-06-23 at 4.56.15 PM.png
Tue, Jun 23, 9:00 PM
F90186352: Screenshot 2026-06-23 at 4.56.23 PM.png
Tue, Jun 23, 9:00 PM
F90180578: Screenshot 2026-06-23 at 4.01.33 PM.png
Tue, Jun 23, 8:07 PM
F90158505: Screenshot 2026-06-23 at 11.46.22 AM.png
Tue, Jun 23, 4:47 PM
F90158504: Screenshot 2026-06-23 at 11.46.16 AM.png
Tue, Jun 23, 4:47 PM
F89134366: Screenshot 2026-06-17 at 8.20.23 AM.png
Jun 17 2026, 3:20 PM
F86746381: Screenshot 2026-06-05 at 8.13.26 AM.png
Jun 5 2026, 12:15 PM
F86635212: Screenshot 2026-06-04 at 12.43.47 PM.png
Jun 4 2026, 4:44 PM

Description

NOTE: impact is only for logged in users

Background

Following T424571: Temporary watchstar status not reflected in dropdown: Add icon support for toolbox in Vector 2022 we inadvertently removed menu collapsing at low resolutions. Thankfully @Sjoerddebruin reported and provided a fix for T426115: Collapsed views items missing from "more" menu at narrow widths in Vector 2022 to restore the items to the menu. However, this raises the question of whether these menu items should have icons similar to the other items in the menu. In this ticket we'll reconsider the behaviour.

For anonymous users, this meant that editors were unable to see edit icons. It was preferable to restore those via T426115: Collapsed views items missing from "more" menu at narrow widths in Vector 2022 given anonymous users are cached to explore our options.

Screenshot 2026-05-12 at 3.53.45 PM.png (553×744 px, 146 KB)

Currently the impact is mainly for logged in users, all items shown to anonymous users do not have icons:

Screenshot 2026-05-12 at 3.55.59 PM.png (564×596 px, 119 KB)

User story

As an editor I want access to the watch star and the page's current watch status at all times.

Requirements

After talking to @Sneha we landed on the following requirements

  • The toolbox should show icons at lower resolutions for all items
  • The toolbox should not show icons at higher resolutions
  • Going forward both watch and bookmark should always appear uncollaped to the right of the history.
  • The bookmark icon should be on the far right and styled as a Codex icon button
  • The watch star should be replaced with a watch link icon for visual cohesion with the rest of the toolbelt.

BDD

  • For QA engineer to fill out

Test Steps

Design

Screenshot 2026-06-02 at 11.50.58 AM.png (521×831 px, 69 KB)

Screenshot 2026-06-02 at 11.51.07 AM.png (1,913×602 px, 84 KB)

Screenshot 2026-06-02 at 11.50.50 AM.png (1,886×642 px, 110 KB)

Screenshot 2026-06-02 at 11.50.42 AM.png (1,917×691 px, 90 KB)

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1298365 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Do not show border bottom on watch star focus

https://gerrit.wikimedia.org/r/1298365

Test wiki created on Patch demo by Jon (WMF) using patch(es) linked to this task:
https://56516456e2.catalyst.wmcloud.org/w/

Reviewed this patch and here are some recommended changes:

  • Reduce the space between star and watch label. Currently its 4px. Make margin-right: 2px; (make sure its also reflected for unwatch state)
  • The current size of the bookmark icon is 16px. Please make it 20px.
  • Add the same hover state "gray box" we have on bookmark icon to the "Watch" button.

Change #1298365 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Design modifications to new watchstar link

https://gerrit.wikimedia.org/r/1298365

Change #1297750 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Create VectorComponentPageToolbar component

https://gerrit.wikimedia.org/r/1297750

Change #1298215 abandoned by Aude:

[mediawiki/skins/Vector@master] Dynamic collapsing of page tools to avoid overflow

https://gerrit.wikimedia.org/r/1298215

Change #1299608 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Reapply "Create VectorComponentPageToolbar component"

https://gerrit.wikimedia.org/r/1299608

Change #1299608 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Reapply "Create VectorComponentPageToolbar component"

https://gerrit.wikimedia.org/r/1299608

Change #1297786 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use VectorComponentMenu in PageToolbar component

https://gerrit.wikimedia.org/r/1297786

Testing this on test.wikipedia.org it seems to have regressed so moving back to ToDo

Screenshot 2026-06-17 at 8.20.23 AM.png (3,238×1,180 px, 517 KB)

Change #1303531 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1303531

Change #1303531 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1303531

Change #1304151 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.47.0-wmf.7] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1304151

Change #1304151 abandoned by Jdlrobson:

[mediawiki/skins/Vector@wmf/1.47.0-wmf.7] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1304151

Change #1304660 had a related patch set uploaded (by Jdlrobson; author: Umherirrender):

[mediawiki/skins/Vector@master] Remove unused private functions from Hooks class

https://gerrit.wikimedia.org/r/1304660

Change #1304151 restored by Jdlrobson:

[mediawiki/skins/Vector@wmf/1.47.0-wmf.7] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1304151

Change #1304151 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.47.0-wmf.7] Ensure page tools icons are only shown on small viewports

https://gerrit.wikimedia.org/r/1304151

Change #1304660 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove unused private functions from Hooks class

https://gerrit.wikimedia.org/r/1304660

Mentioned in SAL (#wikimedia-operations) [2026-06-22T23:25:46Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1304151|Ensure page tools icons are only shown on small viewports (T426131)]], [[gerrit:1304863|Fix duplicate print and other projects menu links in main menu (T429676)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-22T23:27:46Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1304151|Ensure page tools icons are only shown on small viewports (T426131)]], [[gerrit:1304863|Fix duplicate print and other projects menu links in main menu (T429676)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-22T23:34:05Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1304151|Ensure page tools icons are only shown on small viewports (T426131)]], [[gerrit:1304863|Fix duplicate print and other projects menu links in main menu (T429676)]] (duration: 08m 18s)

I am not sure which ticket should this be part of. But the Watchstar size in nav changed in beta from what is in production currently. The production size is correct.

@Sneha can you share a screenshot of what you mean? im not seeing any difference in prod vs testwiki (which is the same as beta). both icons are 16x16

Screenshot 2026-06-23 at 11.46.16 AM.png (2,280×1,422 px, 526 KB)

Screenshot 2026-06-23 at 11.46.22 AM.png (2,270×1,392 px, 754 KB)

Hmm this is what I am seeing. The alignment of watch label with the rest of the links is fixed but notice the star in beta is bigger.

Screenshot 2026-06-23 at 4.01.33 PM.png (2,020×1,412 px, 221 KB)

Hmm this is what I am seeing. The alignment of watch label with the rest of the links is fixed but notice the star in beta is bigger.

Screenshot 2026-06-23 at 4.01.33 PM.png (2,020×1,412 px, 221 KB)

Confirmed - I was wondering about it too

enwiki beta

Screenshot 2026-06-23 at 4.56.23 PM.png (2,116×912 px, 256 KB)

   .vector-menu-tabs .mw-list-item .cdx-button:not(.cdx-button--icon-only) .vector-icon {
    min-width: 10px;
    min-height: 10px;
    width: var(--font-size-medium, 1rem);
    height: var(--font-size-medium, 1rem);
    display: inline-block;
    vertical-align: text-bottom;
    background-size: calc(max(var(--font-size-medium, 1rem), 14px));
}

Screenshot 2026-06-23 at 4.56.15 PM.png (2,074×758 px, 209 KB)

@Etonkovidova just to clarify that I was wondering about the size of the star in front of the watch label. There is a separate ticket for the bookmark icon resize.

@bwang I think the request here is to restore .vector-menu-tabs .mw-list-item.mw-watchlink .vector-icon { mask-size: var(--font-size-small, 0.875rem); }

Change #1305470 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Reduce watchstar icon size

https://gerrit.wikimedia.org/r/1305470

Change #1305499 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.47.0-wmf.8] Reduce watchstar icon size

https://gerrit.wikimedia.org/r/1305499

Change #1305470 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Reduce watchstar icon size

https://gerrit.wikimedia.org/r/1305470

Sneha watchstar icon has now been fixed. Should be visible in around 15m on https://en.wikipedia.beta.wmcloud.org/

Change #1305499 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.47.0-wmf.8] Reduce watchstar icon size

https://gerrit.wikimedia.org/r/1305499

Mentioned in SAL (#wikimedia-operations) [2026-06-24T22:59:27Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1305191|Restore menu tab underline style (T428519)]], [[gerrit:1305499|Reduce watchstar icon size (T426131)]], [[gerrit:1305444|Replace Tools button with vertical ellipsis (T429258)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-24T23:01:38Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1305191|Restore menu tab underline style (T428519)]], [[gerrit:1305499|Reduce watchstar icon size (T426131)]], [[gerrit:1305444|Replace Tools button with vertical ellipsis (T429258)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-24T23:06:48Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305191|Restore menu tab underline style (T428519)]], [[gerrit:1305499|Reduce watchstar icon size (T426131)]], [[gerrit:1305444|Replace Tools button with vertical ellipsis (T429258)]] (duration: 07m 21s)

Just checked. Looks good to me now.

Looks great on production on both Firefox and Chrome.

Test wiki on Patch demo by Jon (WMF) using patch(es) linked to this task was deleted:

https://b399a949af.catalyst.wmcloud.org/w/

Test wiki on Patch demo by Jon (WMF) using patch(es) linked to this task was deleted:

https://e119976ba7.catalyst.wmcloud.org/w/

Test wiki on Patch demo by Jon (WMF) using patch(es) linked to this task was deleted:

https://dbbbb1445f.catalyst.wmcloud.org/w/

Test wiki on Patch demo by Jon (WMF) using patch(es) linked to this task was deleted:

https://56516456e2.catalyst.wmcloud.org/w/