The logic in the PageEdit class is currently covered by EditPageTest. This results in a coverage of ~85%. However, many edge cases and parts of the behaviour aren't technically covered by tests/assertions.
Some parts of PageEdit::doEdit should be split up into smaller methods that are easier to test, and there should be tests testing the full logic that don't rely on EditPage, as PageEdit will be used outside of EditPage as well in the future.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| PageEdit: Split hasConflict() out of doEdit() and add tests for it | SomeRandomDeveloper | mediawiki/core | master | +186 -51 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T20654 EditPage.php needs rewrite: Separate DB and UI logic | |||
| Open | None | T157658 Factor out a backend from EditPage | |||
| Open | SomeRandomDeveloper | T426012 Add separate tests for PageEdit and increase the code coverage |
Event Timeline
Comment Actions
Change #1297226 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[mediawiki/core@master] PageEdit: Split hasConflict() out of doEdit() and add tests for it
Comment Actions
Change #1297226 merged by jenkins-bot:
[mediawiki/core@master] PageEdit: Split hasConflict() out of doEdit() and add tests for it