Page MenuHomePhabricator

Error: Unknown task type revise-tone
Open, Needs TriagePublicPRODUCTION ERROR

Description

Error
message
Error: Unknown task type revise-tone
trace
at new TaskExplanationWidget  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:422:554
at SuggestedEditsModule.updateTaskExplanationWidget  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:405:742
at SuggestedEditsModule.updateControls  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:410:783
at SuggestedEditsModule.onNewcomerTasksDataChanged  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:406:52
at OO.EventEmitter.emit  https://en.wikipedia.org/w/load.php?lang=en&modules=oojs&skin=vector-2022&version=rwdvu:8:193
at NewcomerTasksStore.onTaskQueueChanged  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.DataStore&skin=vector-2022&version=84hq6:10:390
at NewcomerTasksStore.setPreloadedTaskQueue  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.DataStore&skin=vector-2022&version=84hq6:9:974
at initSuggestedTasks  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:395:339
at https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:396:839
at index.js  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.Impact%2CSuggestedEdits&skin=vector-2022&version=119b6:397:70
Impact
Notes
  • I checked a test user with Revise tone task type enabled - all works as expected

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This seems to be happening since the beginning of the experiment, which started on March 31 and the relevant code hit enwiki on April 2nd (see last 90 days). This happens if for some yet unknown reason GrowthExperiments considers the user to be in the treatment group in FeatureManager.php#63 and to be in the control group or unenrolled in TaskTypesAbFilter.js#87. Given these are very few hits across ~300K subjects in the experiment from an analysis pov it doesn't seem relevant. The bad think is that users are getting a broken task card which fails to load the image and description and won't trigger a revise tone task flow.

Maybe some better error handling and fallback to some available task and maybe stop analytics logs for this users? Otoh, given this is a logged-in only experiment, I don't see a fair reason to fail on returning the same group for the same user, so maybe this should be investigated forward in Test Kitchen. What do you think @Michael ?