Page MenuHomePhabricator
Create Task
Maniphest T424597

Make use of the mw.libs.confirmEdit.CaptchaWidget in DiscussionTools instead of CaptchaInputWidget
Open, Needs TriagePublic
Actions

Description

Summary

In T422913: Rework mw.libs.confirmEdit.CaptchaInputWidget to not always require an input field, the mw.libs.confirmEdit.CaptchaInputWidget class was replaced with the mw.libs.confirmEdit.CaptchaWidget class. The latter supports hCaptcha. We should use CaptchaWidget in DiscussionTools instead of CaptchaInputWidget to allow hCaptcha to be enabled for that interface

Background & Technical details

  • mw.libs.confirmEdit.CaptchaInputWidget relies on the idea that the captcha will always have an input field to be rendered
    • However hCaptcha violates this assumption as it renders it's own widget and does not use a text field for the user to enter text
    • Therefore, the CaptchaInputWidget needed refactoring to support hCaptcha and a rename to make it clear that there will not always be a input field
  • This means that the mw.libs.confirmEdit.CaptchaInputWidget class has been deprecated and DiscussionTools should use the mw.libs.confirmEdit.CaptchaWidget class instead
    • The CaptchaWidget class still supports all the captcha types supported by CaptchaInputWidget, so changing this does not represent a backwards step in compatibility

Acceptance criteria

  • DiscussionTools uses mw.libs.confirmEdit.CaptchaWidget instead of mw.libs.confirmEdit.CaptchaInputWidget

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
dt.ui.ReplyWidget.test.js: Use sinion mocks where possiblemediawiki/extensions/DiscussionToolsmaster+27 -57
Surface CAPTCHA rendering errors and log themmediawiki/extensions/DiscussionToolsmaster+80 -0
ReplyWidget: Fix bug with CAPTCHA input element focusmediawiki/extensions/DiscussionToolsmaster+1 -1
Pass all CAPTCHA fields to edit API in discussiontoolseditmediawiki/extensions/DiscussionToolsmaster+125 -7
Use mw.libs.confirmEdit.CaptchaWidget in DiscussionToolsmediawiki/extensions/DiscussionToolsmaster+241 -113
Add SimpleCaptcha::getApiParamsmediawiki/extensions/ConfirmEditmaster+88 -0
Add tests for ApiDiscussionToolsEditmediawiki/extensions/DiscussionToolsmaster+90 -0
zuul: [mediawiki/extensions/DiscussionTools] Add ConfirmEdit dependencyintegration/configmaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Apr 27 2026, 11:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2026, 11:41 PM
Dreamy_Jazz edited projects, added hCaptcha, Bot detection and mitigation (WE4.10 hCaptcha); removed Bot detection and mitigation (WE4.2 hCaptcha editing trial), affects-Miraheze.Apr 27 2026, 11:41 PM
Dreamy_Jazz added a subtask: T422913: Rework mw.libs.confirmEdit.CaptchaInputWidget to not always require an input field.
Dreamy_Jazz added a parent task: T424598: Update ConvenientDiscussions to use mw.libs.confirmEdit.CaptchaWidget instead of mw.libs.confirmEdit.CaptchaInputWidget.Apr 27 2026, 11:48 PM
gerritbot added a comment.Apr 28 2026, 12:22 AM

Change #1277801 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] [WIP] Use mw.libs.confirmEdit.CaptchaWidget in DiscussionTools

https://gerrit.wikimedia.org/r/1277801

gerritbot added a project: Patch-For-Review.Apr 28 2026, 12:22 AM
KockaAdmiralac subscribed.Apr 28 2026, 1:26 AM
Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)) board.Apr 28 2026, 2:53 PM
gerritbot added a comment.Apr 29 2026, 11:59 AM

Change #1279288 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] [WIP] Add SimpleCaptcha::getApiParams

https://gerrit.wikimedia.org/r/1279288

gerritbot added a comment.Apr 29 2026, 2:02 PM

Change #1279369 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] Add tests for ApiDiscussionToolsEdit

https://gerrit.wikimedia.org/r/1279369

gerritbot added a comment.Apr 29 2026, 2:02 PM

Change #1279370 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] [WIP] Pass all CAPTCHA fields to edit API in discussiontoolsedit

https://gerrit.wikimedia.org/r/1279370

gerritbot added a comment.Apr 29 2026, 2:25 PM

Change #1279378 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[integration/config@master] zuul: [mediawiki/extensions/DiscussionTools] Add ConfirmEdit dependency

https://gerrit.wikimedia.org/r/1279378

gerritbot added a comment.Apr 29 2026, 3:45 PM

Change #1279378 merged by jenkins-bot:

[integration/config@master] zuul: [mediawiki/extensions/DiscussionTools] Add ConfirmEdit dependency

https://gerrit.wikimedia.org/r/1279378

Stashbot added a comment.Apr 29 2026, 3:49 PM

Mentioned in SAL (#wikimedia-releng) [2026-04-29T15:49:19Z] <James_F> Zuul: [mediawiki/extensions/DiscussionTools] Add ConfirmEdit dependency, for T424597

OKryva-WMF edited projects, added Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)); removed Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)).May 1 2026, 7:45 AM
OKryva-WMF moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.May 1 2026, 7:45 AM
Dreamy_Jazz moved this task from Backlog to In progress on the Bot detection and mitigation (WE4.10 hCaptcha) board.Fri, May 8, 10:34 PM
Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.
gerritbot added a comment.Mon, May 11, 10:24 AM

Change #1279369 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add tests for ApiDiscussionToolsEdit

https://gerrit.wikimedia.org/r/1279369

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Mon, May 11, 11:00 AM
gerritbot added a comment.Mon, May 11, 1:53 PM

Change #1279288 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Add SimpleCaptcha::getApiParams

https://gerrit.wikimedia.org/r/1279288

gerritbot added a comment.Mon, May 11, 1:53 PM

Change #1279370 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Pass all CAPTCHA fields to edit API in discussiontoolsedit

https://gerrit.wikimedia.org/r/1279370

gerritbot added a comment.Mon, May 11, 1:53 PM

Change #1277801 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use mw.libs.confirmEdit.CaptchaWidget in DiscussionTools

https://gerrit.wikimedia.org/r/1277801

Dreamy_Jazz updated the task description. (Show Details)Mon, May 11, 2:02 PM
Dreamy_Jazz moved this task from In progress to QA on the Bot detection and mitigation (WE4.10 hCaptcha) board.
Dreamy_Jazz moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.
Maintenance_bot removed a project: Patch-For-Review.Mon, May 11, 2:32 PM
gerritbot added a comment.Tue, May 12, 10:37 PM

Change #1286520 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Fix bug with CAPTCHA input element focus

https://gerrit.wikimedia.org/r/1286520

gerritbot added a project: Patch-For-Review.Tue, May 12, 10:37 PM
gerritbot added a comment.Tue, May 12, 11:57 PM

Change #1286529 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] dt.ui.ReplyWidget.test.js: Use sinion mocks where possible

https://gerrit.wikimedia.org/r/1286529

gerritbot added a comment.Tue, May 12, 11:58 PM

Change #1285876 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/DiscussionTools@master] Surface CAPTCHA rendering errors and log them

https://gerrit.wikimedia.org/r/1285876

Dreamy_Jazz moved this task from QA in Prod to Needs review on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Tue, May 12, 11:59 PM
gerritbot added a comment.Wed, May 13, 9:28 AM

Change #1286520 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Fix bug with CAPTCHA input element focus

https://gerrit.wikimedia.org/r/1286520

gerritbot added a comment.Wed, May 13, 9:47 AM

Change #1285876 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Surface CAPTCHA rendering errors and log them

https://gerrit.wikimedia.org/r/1285876

gerritbot added a comment.Wed, May 13, 9:58 AM

Change #1286529 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] dt.ui.ReplyWidget.test.js: Use sinion mocks where possible

https://gerrit.wikimedia.org/r/1286529

ReleaseTaggerBot edited projects, added MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Wed, May 13, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Wed, May 13, 10:32 AM
Dreamy_Jazz moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Wed, May 13, 11:49 AM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)); removed Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)).Mon, May 25, 12:38 PM
OKryva-WMF moved this task from Backlog to QA in Prod on the Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)) board.Mon, May 25, 12:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits