Note: $wgWatchlistExpiry = true; needs to be set in LocalSettings.php to match production.

Background

ReadingLists moves the watchstar to the toolbox menu. However since that menu does not support icons, the end user loses information about whether the article is temporarily being watched. I suggest we add support for icons in the toolbox.

User story

As a logged in user I want to see if an article is temporarily watched for 3 months or permanently watched

Requirements

• Add task requirements. Requirements should be user-centric, well-defined, unambiguous, implementable, testable, consistent, and comprehensive

BDD

Scenario 1: On Mobile a user sees the temp watchstar icon for pages temporarioy added to a user's Watchlist

Given a user is logged in on mobile and goes to an article page
When a user clicks the Watchstar in the tool menu and selects an option to watch it temporarily
Then a user sees a Watchstar icon half-filled

Scenario 2: a user sees the icons for items in the Toolbox menu

Given a user is logged in and goes to an article page
When a user clicks the tool menu
Then a user sees the icons for items in "Actions" menu - Delete, protect, watch and move
And menu items in General sections do not have cons

Test Steps

• check the above scenarios for Desktop and mobile (admin and normal users)
• checkDark mode

Design

Acceptance criteria

• Icons appear for menus in "Actions" menu (Delete, protect, watch and move). [to test these you'll need to login as a sysadmin or someone with similar user rights]
• Icons do not appear for items below actions (e.g. General)

Communication criteria - does this need an announcement or discussion?

• Add communication criteria

Rollback plan

• What is the rollback plan in production for this task if something goes wrong?

In the event of pushback from editors (admins disliking the new icons for move, delete, protect), there is a short term and a long term fix

short term

the icons for non-watchstar can be disabled via a CSS addition for a quick revert that keeps the bug fix intact:

div#p-cactions li:not(.mw-watchlink) .vector-icon {
    display: none;
}

long term

In future Bernard's refactor allows us more fine grained control over which icons to show which would support disabling other icons using https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1285450

Given similar issues with the donate link icon, I suggest we then take some time to evaluate the overall architecture to support selective icons better before rushing to a longer solution.

This task was created by Version 1.2.0 of the Web team task template using phabulous