Page MenuHomePhabricator
Create Task
Maniphest T423701

Serialize ContentHolder (or at least its fragments) in ParserOutput
Open, Needs TriagePublic
Actions

Description

If we add other fragments than body to the ContentHolder, we need to serialize these in ParserOutput. Whether it's easier/better to serialize the whole ContentHolder or to only serialize its fragments is left as an exercise to the implementer.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Serialize ContentHolder in ParserOutputmediawiki/coremaster+5 -11
Forward-compatibility for serialization of ContentHolder in ParserOutputmediawiki/coreREL1_46+161 -7
Forward-compatibility for serialization of ContentHolder in ParserOutputmediawiki/corewmf/1.47.0-wmf.3+142 -16
Forward-compatibility for serialization of ContentHolder in ParserOutputmediawiki/coremaster+142 -16
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendorwmf/1.47.0-wmf.1+14 K -14 K
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendormaster+14 K -14 K
Introduce BasePageBundle::hasContent and make isEmpty a negative proxymediawiki/services/parsoidmaster+18 -6
Add a method to check whether a BasePageBundle is emptymediawiki/services/parsoidREL1_45+8 -0
Bump wikimedia/parsoid to 0.23.0-a29mediawiki/vendormaster+1 K -213
Add a method to check whether a BasePageBundle is emptymediawiki/services/parsoidmaster+9 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ihurbain created this task.Apr 17 2026, 1:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2026, 1:16 PM
gerritbot added a comment.Apr 17 2026, 2:50 PM

Change #1273838 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Forward-compatibility for serialization of ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1273838

gerritbot added a project: Patch-For-Review.Apr 17 2026, 2:50 PM

Change #1273839 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Serialize ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1273839

gerritbot added a comment.Apr 27 2026, 3:49 PM

Change #1277587 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Add a method to check whether a BasePageBundle is empty

https://gerrit.wikimedia.org/r/1277587

gerritbot added a comment.Apr 27 2026, 4:08 PM

Change #1277587 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add a method to check whether a BasePageBundle is empty

https://gerrit.wikimedia.org/r/1277587

gerritbot added a comment.Apr 27 2026, 6:09 PM

Change #1277671 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a29

https://gerrit.wikimedia.org/r/1277671

gerritbot added a comment.Apr 27 2026, 8:15 PM

Change #1277671 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a29

https://gerrit.wikimedia.org/r/1277671

gerritbot added a comment.Apr 28 2026, 9:57 PM

Change #1278646 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@REL1_45] Add a method to check whether a BasePageBundle is empty

https://gerrit.wikimedia.org/r/1278646

gerritbot added a comment.Apr 28 2026, 10:51 PM

Change #1278646 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_45] Add a method to check whether a BasePageBundle is empty

https://gerrit.wikimedia.org/r/1278646

gerritbot added a comment.Apr 30 2026, 1:34 PM

Change #1280416 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Introduce BasePageBundle::hasContent and make isEmpty a negative proxy

https://gerrit.wikimedia.org/r/1280416

gerritbot added a comment.Mon, May 4, 7:45 PM

Change #1280416 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Introduce BasePageBundle::hasContent and make isEmpty a negative proxy

https://gerrit.wikimedia.org/r/1280416

gerritbot added a comment.Thu, May 7, 7:44 PM

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.Thu, May 7, 8:02 PM

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.Thu, May 7, 8:16 PM

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

gerritbot added a comment.Thu, May 7, 9:07 PM

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Stashbot mentioned this in T368724: Rendering diff on broken link with template (visual diff testing).Thu, May 7, 9:15 PM
Stashbot mentioned this in T424773: __NOCONTENTCONVERT__ is not honored in Parsoid.
Stashbot mentioned this in T319058: ParserTests defaults to wgAllowExternalImages=true.
Stashbot mentioned this in T424446: Space added for no reason.
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids..
Stashbot mentioned this in T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages.
Stashbot mentioned this in T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio.
Stashbot mentioned this in T425731: CTT tasks week of 2026-05-01.
Stashbot mentioned this in T373384: Parsoid doesn't properly handle double-underscore magic words.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Stashbot mentioned this in T423241: Thumbtime for TimedMedia no longer working.Thu, May 7, 9:16 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Stashbot added a comment.Thu, May 7, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

ihurbain moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.Mon, May 11, 3:21 PM
gerritbot added a comment.Tue, May 19, 2:55 AM

Change #1273838 merged by jenkins-bot:

[mediawiki/core@master] Forward-compatibility for serialization of ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1273838

gerritbot added a comment.Tue, May 19, 4:05 AM

Change #1289070 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/core@wmf/1.47.0-wmf.3] Forward-compatibility for serialization of ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1289070

gerritbot added a comment.Tue, May 19, 1:15 PM

Change #1289070 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.3] Forward-compatibility for serialization of ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1289070

Stashbot added a comment.Tue, May 19, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:23:20Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]]

Stashbot added a comment.Tue, May 19, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:25:24Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Tue, May 19, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:36:16Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]] (duration: 12m 56s)

gerritbot added a comment.Fri, May 22, 9:21 PM

Change #1273839 merged by jenkins-bot:

[mediawiki/core@master] Serialize ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1273839

Maintenance_bot removed a project: Patch-For-Review.Fri, May 22, 9:30 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).Fri, May 22, 10:00 PM
gerritbot added a comment.Fri, May 22, 10:02 PM

Change #1292271 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/core@REL1_46] Forward-compatibility for serialization of ContentHolder in ParserOutput

https://gerrit.wikimedia.org/r/1292271

gerritbot added a project: Patch-For-Review.Fri, May 22, 10:02 PM
ihurbain moved this task from Code Review to To Verify on the Content-Transform-Team (Work In Progress) board.Tue, May 26, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits