Page MenuHomePhabricator

Rework mw.libs.confirmEdit.CaptchaInputWidget to not always require an input field
Open, Needs TriagePublic

Description

Summary

mw.libs.confirmEdit.CaptchaInputWidget is used by other extensions to load a CAPTCHA widget via JS code, such as by DiscussionTools. We should refactor and rename it to not always display an input field, as some CAPTCHAs (like hCaptcha) don't use an input field but implement their own UI

Acceptance criteria

  • A replacement for mw.libs.confirmEdit.CaptchaInputWidget is added that does not assume an input field is always needed
  • The new code can display nothing but the CAPTCHA widget (without any other specific styling) if requested, so it can be added into an element that already defines it's own custom styling

Event Timeline

Change #1270051 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] [Very WIP] Create mw.libs.confirmEdit.CaptchaWidget

https://gerrit.wikimedia.org/r/1270051

Change #1277215 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] [WIP] ext.confirmEdit.CaptchaWidget: Add FancyCaptcha support

https://gerrit.wikimedia.org/r/1277215

Change #1277216 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] Move CaptchaInputWidget module definition to specific handler

https://gerrit.wikimedia.org/r/1277216

Change #1277780 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] [WIP] Deprecate mw.libs.confirmEdit.CaptchaInputWidget

https://gerrit.wikimedia.org/r/1277780

Change #1277216 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Move CaptchaInputWidget module definition to specific handler

https://gerrit.wikimedia.org/r/1277216

Change #1277214 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.CaptchaWidget: Support QuestyCaptcha

https://gerrit.wikimedia.org/r/1277214

Change #1284548 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] Move early return to start of MakeGlobalVariablesScriptHandler

https://gerrit.wikimedia.org/r/1284548

Change #1270051 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Create mw.libs.confirmEdit.CaptchaWidget

https://gerrit.wikimedia.org/r/1270051

Change #1284548 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Move early return to start of MakeGlobalVariablesScriptHandler

https://gerrit.wikimedia.org/r/1284548

Change #1277214 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.CaptchaWidget: Support QuestyCaptcha and SimpleCaptcha

https://gerrit.wikimedia.org/r/1277214

Change #1277215 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.CaptchaWidget: Add FancyCaptcha support

https://gerrit.wikimedia.org/r/1277215

Change #1277780 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Deprecate mw.libs.confirmEdit.CaptchaInputWidget

https://gerrit.wikimedia.org/r/1277780

Change #1286512 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] Clarify docs for mw.libs.confirmEdit.CaptchaWidget.getInputField

https://gerrit.wikimedia.org/r/1286512

Change #1286512 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Clarify docs for mw.libs.confirmEdit.CaptchaWidget.getInputField

https://gerrit.wikimedia.org/r/1286512