Page MenuHomePhabricator

If one TA is not registered on the local wiki IP Auto-Reveal fails for all TAs on the page
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Observe that none of the TAs are annotated with IP addresses (though they are available via Show IP)

The batch-temporaryaccount request fails with 404, response:

{
    "errorKey": "rest-nonexistent-user",
    "messageTranslations": {
        "en": "The specified user (~2026-20584-66) does not exist"
    },
    "httpCode": 404,
    "httpReason": "Not Found"
}

What should have happened instead?:
Partial results should be returned and used for annotation.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It looks like the batch endpoint could benefit from skipping non-existent users and returning partial results, rather than failing the entire request when one TA isn't found locally.

Change #1268596 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/extensions/CheckUser@master] Skip non-existent users in batch-temporaryaccount endpoint

https://gerrit.wikimedia.org/r/1268596

Change #1268596 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Skip non-existent users in batch-temporaryaccount endpoint

https://gerrit.wikimedia.org/r/1268596

HakanIST claimed this task.

The fix has been merged in Change #1268596. The batch-temporaryaccount endpoint now skips non-existent users and returns partial results instead of failing the entire request with a 404. Closing as resolved.