Page MenuHomePhabricator
Create Task
Maniphest T418988

Language selector: Use the component on Special:Translate
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Replace the language selector on Special:Translate with the new language selector if it is enabled.

image.png (812×1 px, 65 KB)

Some tweaks maybe needed to the language selector.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SpecialTranslate: Set display language code for the language selectormediawiki/extensions/Translatemaster+1 -0
ULS rewrite: Allow specifying the display language code for itemsmediawiki/extensions/UniversalLanguageSelectormaster+27 -3
ULS rewrite: Handle longer language names bettermediawiki/extensions/UniversalLanguageSelectormaster+6 -3
SpecialTranslate: Load the new ULS rewrite if enabledmediawiki/extensions/Translatemaster+59 -22
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Mar 4 2026, 10:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2026, 10:37 AM
abi_ moved this task from Backlog to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Mar 4 2026, 10:37 AM
gerritbot added a comment.Mar 4 2026, 10:37 AM

Change #1247958 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SpecialTranslate: Load the new ULS rewrite if enabled

https://gerrit.wikimedia.org/r/1247958

gerritbot added a project: Patch-For-Review.Mar 4 2026, 10:37 AM
hueitan moved this task from Backlog to In progress on the LPL Projects (ULS rewrite) board.Mar 17 2026, 6:36 PM
abi_ added a comment.Mar 18 2026, 2:29 PM

Created: https://phabricator.wikimedia.org/T419546 to track addition of custom regions.

abi_ changed the task status from Open to In Progress.Mar 24 2026, 3:22 PM
abi_ raised the priority of this task from Medium to High.
gerritbot added a comment.Mar 24 2026, 4:04 PM

Change #1247958 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SpecialTranslate: Load the new ULS rewrite if enabled

https://gerrit.wikimedia.org/r/1247958

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2026, 4:32 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 24 2026, 5:00 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Mar 26 2026, 10:36 AM
abi_ moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q3&4) board.Mar 29 2026, 5:24 PM

Can be tested on patch demo https://2256d7c2c9.catalyst.wmcloud.org/w/index.php?title=Special%3ATranslate&group=page-TranslatablePage&action=page&filter=&action_source=translate_page&language=en when logged in as Patch Demo user.

Nikerabbit subscribed.Mar 31 2026, 8:33 AM

If IME is enabled, after changing a language the screen width scrolls due to mispositioned IME icon:

image.png (533×1 px, 105 KB)

When using it in Finnish, there is a horizontal scrollbar:

image.png (499×722 px, 97 KB)

Nikerabbit moved this task from Need QA to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Mar 31 2026, 8:35 AM
gerritbot added a comment.Apr 1 2026, 1:10 AM

Change #1265653 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Handle longer language names better

https://gerrit.wikimedia.org/r/1265653

gerritbot added a project: Patch-For-Review.Apr 1 2026, 1:10 AM
Nikerabbit added a comment.Apr 1 2026, 6:51 AM

And one more:

We are setting lang=XXX attribute as the target language. That is not correct when we are displaying language names in the user language.

gerritbot added a comment.Apr 1 2026, 7:03 AM

Change #1265653 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Handle longer language names better

https://gerrit.wikimedia.org/r/1265653

Nikerabbit mentioned this in T419741: Replace interface language selector with the new language selector.Apr 1 2026, 7:17 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2026, 7:30 AM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.23; 2026-04-07); removed MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Apr 1 2026, 8:01 AM
gerritbot added a comment.Apr 1 2026, 3:48 PM

Change #1266304 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SpecialTranslate: Set display language code for the language selector

https://gerrit.wikimedia.org/r/1266304

gerritbot added a project: Patch-For-Review.Apr 1 2026, 3:48 PM
gerritbot added a comment.Apr 1 2026, 4:03 PM

Change #1266310 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Allow specifying the display language code for items

https://gerrit.wikimedia.org/r/1266310

abi_ added a comment.Apr 2 2026, 12:15 PM

Thanks for the QA report!

In T418988#11770929, @Nikerabbit wrote:

If IME is enabled, after changing a language the screen width scrolls due to mispositioned IME icon:

image.png (533×1 px, 105 KB)

I'm not able to reproduce this issue but I do see some inconsistencies. Maybe this was being caused by the horizontal scrollbar that was appearing? One option would be to trigger a window resize event whenever a language is selected and that might fix the issue.

When using it in Finnish, there is a horizontal scrollbar:

image.png (499×722 px, 97 KB)

Fixed in 1265653: ULS rewrite: Handle longer language names better | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1265653

In T418988#11776351, @Nikerabbit wrote:

And one more:

We are setting lang=XXX attribute as the target language. That is not correct when we are displaying language names in the user language.

Fixed in 1266310: ULS rewrite: Allow specifying the display language code for items | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1266310 and 1266304: SpecialTranslate: Set display language code for the language selector | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1266304

gerritbot added a comment.Apr 9 2026, 11:20 AM

Change #1266310 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Allow specifying the display language code for items

https://gerrit.wikimedia.org/r/1266310

gerritbot added a comment.Apr 9 2026, 11:38 AM

Change #1266304 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SpecialTranslate: Set display language code for the language selector

https://gerrit.wikimedia.org/r/1266304

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed MW-1.46-notes (1.46.0-wmf.23; 2026-04-07).Apr 9 2026, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2026, 12:31 PM
Nikerabbit moved this task from In Progress to Need QA on the LPL Essential (FY2025-26 Q3&4) board.Apr 13 2026, 7:37 AM
Nikerabbit closed this task as Resolved.Apr 14 2026, 8:05 AM
Nikerabbit moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q3&4) board.

Not able to reproduce the IME issue consistently anymore. Hard refresh (shift-reload) seemed to have fixed it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits