Page MenuHomePhabricator

Make it easy for extensions to test ownership
Closed, ResolvedPublic

Description

Background

WikimediaEvents, MobileFrontend and now WikimediaCustomizations make use of a OWNERS.md. The former 2 also have tests to enforce it. Going forward it would be good to share a central definition of what ownership looks like so any new extension (including WikimediaCustomizations) can make use of it.

User story

As a developer I want it to be easy to enforce ownership in my repo

Requirements

  • An abstract class exists in core
  • MobileFrontend uses the abstract class
  • WikimediaCustomizations the abstract class

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1233890 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Use MediaWiki\Tests\Structure\OwnersStructureTestBase

https://gerrit.wikimedia.org/r/1233890

Change #1233891 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Add a general OwnersStructureTestBase to MediaWiki

https://gerrit.wikimedia.org/r/1233891

Change #1233892 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Use MediaWiki\Tests\Structure\OwnersStructureTestBase

https://gerrit.wikimedia.org/r/1233892

Change #1233928 had a related patch set uploaded (by Jdlrobson; author: Gergő Tisza):

[mediawiki/extensions/WikimediaCustomizations@master] Enforce claiming of files and folders via OWNERS.md

https://gerrit.wikimedia.org/r/1233928

@Tgr @Catrope let me know what you think. The test I'm submitting to core is compatible with both WikimediaEvents and MobileFrontend and follows the precedent set by tests/phpunit/structure/BundleSizeTestBase.php

I'm planning to add some code to this extension in the next 3 months so am motivated to help clean up our ecosystem a little bit!

Jdlrobson-WMF lowered the priority of this task from Medium to Low.Mar 19 2026, 6:29 PM
Jdlrobson-WMF raised the priority of this task from Low to Medium.Mar 25 2026, 4:32 PM
Jdlrobson-WMF added a project: QuickSurveys.

QuickSurveys will also use this now so raising priority.

Change #1260862 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Add OWNERS.md to QuickSurveys

https://gerrit.wikimedia.org/r/1260862

Change #1233891 merged by jenkins-bot:

[mediawiki/core@master] Add a general OwnersStructureTestBase to MediaWiki

https://gerrit.wikimedia.org/r/1233891

Change #1233890 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use MediaWiki\Tests\Structure\OwnersStructureTestBase

https://gerrit.wikimedia.org/r/1233890

Change #1233928 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Check all files and folders are claimed via OWNERS.md

https://gerrit.wikimedia.org/r/1233928

Jdlrobson-WMF updated the task description. (Show Details)

Change #1233892 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Use MediaWiki\Tests\Structure\OwnersStructureTestBase

https://gerrit.wikimedia.org/r/1233892

Change #1260862 abandoned by Jdlrobson:

[mediawiki/extensions/QuickSurveys@master] Add OWNERS.md to QuickSurveys

Reason:

Not a focus for now.

https://gerrit.wikimedia.org/r/1260862