Create a Discover settings screen
- Settings options such as how many articles, the frequency of updates...etc.
- Links to other screens for selecting base and articles.
- Add "Discover settings" option in the general Settings screen
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | HNordeenWMF | T392166 [Epic] [WE 3.1.15] Personalized Reading list on Android | |||
| Resolved | WRai-WMF | T394056 [WE 3.1.15] Create a "Discover" settings screen |
Event Timeline
Comment Actions
HI @SChekfa-WMF , this is ready for design review.
https://github.com/wikimedia/apps-android-wikipedia/actions/runs/15352717358
Note 1. Interest screen will not open because it is still in development. The actual notification functionality is in different ticket. However, all design elements and options are now ready for review.
Comment Actions
thanks for working on this!
some notes:
- right now the Discover reading list item containing the switch that toggles the list on/off is set very high on the screen — can we ensure it's placed lower, like other settings components? it should be 16px below the top app bar.
- can we make sure that the styling of the switch, both on/off, aligns with the styling of the switch in the other settings options outside the discover list? I realized that the styles aren't inheriting properly — I've updated the Figma file to reflect this. also, there should be no border around the on switch. same goes for the switch associated with "notifications."
- can we make sure the margin around the dividers is always 24px? right now the top margin associated with the divider below "Updates weekly" and the bottom border associated with the divider above "Notifications" look a bit narrow.
- can we makes sure the dividers are referencing the <border> color token at 1px? it looks a bit dark/thick right now.
- can we switch the order of the CTAs in the notification dialog so that "Turn them off" is on the left and "No, keep them on" is on the right?
other than that, I know you mentioned Interests don't work just yet — has the configuration for setting up a list with reading history / saved articles been set up? it's not showing up for me (the reason I ask is because I want to test that the # of articles being recommended is correct).
Comment Actions
Are you referring to the areas I marked in red?
Hi @SChekfa-WMF, thank you for your review.
3. can we make sure the margin around the dividers is always 24px? right now the top margin associated with the divider below "Updates weekly" and the bottom border associated with the divider above "Notifications" look a bit narrow.
Are you referring to the areas I marked in red?
other than that, I know you mentioned Interests don't work just yet — has the configuration for setting up a list with reading history / saved articles been set up? it's not showing up for me (the reason I ask is because I want to test that the # of articles being recommended is correct).
You should be able to select them from How discover is built option.
https://drive.google.com/file/d/1ZF4xoHKs4g_R4wF_Dkh1Pq93CS0RTM5o/view?usp=sharing
Comment Actions
hi @WRai-WMF, thank you for following up —
- yes!
- yes, that's the process I followed, but for some reason the Discover list did not show up for me under Saved — see below screenshots of my settings / Saved:
Comment Actions
Hi @SChekfa-WMF , the work for displaying the Discover list is currently in progress and is part of the Discover List PR. Apologies for not mentioning that earlier. I submitted this for design review to get feedback on the settings designs and some of the functionality that has already been merged.
Here is the APK with the updated ui fixes.
https://github.com/wikimedia/apps-android-wikipedia/actions/runs/15424150083
Comment Actions
hi @WRai-WMF, thank you for fixing! looks great, just one last thing —
can we make sure the CTAs for turning Discover off reference "it" rather than "them"?
here's how it is now:
here's how it should be:
thank you!