Page MenuHomePhabricator
Create Task
Maniphest T386530

Add native support for ES2018-ES2020 to the minifier
Closed, ResolvedPublic
Actions

Description

Previous: T277675: Add native support for ES2016-ES2017 to the minifier | Next: T425099: Add native support for ES2021 to the minifier

Notable syntax features in later versions:

Details

Other Assignee
Krinkle
Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Feb 14 2025, 11:37 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptFeb 14 2025, 11:37 PM
Krinkle renamed this task from Add native support for ES2018-ES2020 or higher versions to the minifier to Add native support for ES2018-ES2020 to the minifier.Feb 14 2025, 11:37 PM
Krinkle mentioned this in T277675: Add native support for ES2016-ES2017 to the minifier.
Novem_Linguae subscribed.Feb 14 2025, 11:40 PM
Nemoralis subscribed.Feb 15 2025, 1:44 AM
Escargot_rouge subscribed.Feb 24 2025, 1:54 PM
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.Feb 25 2025, 8:29 PM
ExE-Boss subscribed.Feb 26 2025, 5:50 AM
• Hokwelum closed subtask T387432: Add minification support for optional catch binding as Resolved.Mar 6 2025, 9:54 PM
Krinkle updated the task description. (Show Details)Mar 18 2025, 9:37 PM
• Hokwelum updated the task description. (Show Details)Mar 21 2025, 6:39 PM
gerritbot added a comment.Mar 21 2025, 6:48 PM

Change #1130172 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2017 support

https://gerrit.wikimedia.org/r/1130172

gerritbot added a project: Patch-For-Review.Mar 21 2025, 6:48 PM
Krinkle closed subtask T387122: Add support for async iteration (for await) as Resolved.Apr 20 2025, 8:30 PM
Krinkle triaged this task as Low priority.Apr 20 2025, 8:33 PM
Krinkle updated the task description. (Show Details)
Krinkle mentioned this in T395347: Raise Grade A JavaScript requirement from ES2017 to ES2018 (ECMAScript 9).May 29 2025, 8:49 PM
Novem_Linguae removed a project: Patch-For-Review.Jun 11 2025, 3:28 AM
gerritbot added a comment.Jun 11 2025, 4:03 AM

Change #1155362 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/libs/Minify@master] tests: add ES2018 RegEx lookbehinds

https://gerrit.wikimedia.org/r/1155362

gerritbot added a project: Patch-For-Review.Jun 11 2025, 4:03 AM
mxn subscribed.Jul 24 2025, 6:57 AM
jleedev subscribed.Jul 24 2025, 7:47 AM
Michael subscribed.Jul 29 2025, 3:30 PM
gerritbot added a comment.Dec 18 2025, 1:24 AM

Change #1155362 merged by jenkins-bot:

[mediawiki/libs/Minify@master] tests: Add tests for ES2018 syntax

https://gerrit.wikimedia.org/r/1155362

Michael mentioned this in T419142: Raise Grade A JavaScript requirement from ES2018 to ES2019 (ECMAScript 10).Mar 5 2026, 3:56 PM
Mr._Starfleet_Command subscribed.Mar 5 2026, 4:37 PM
Volker_E subscribed.Mar 5 2026, 8:16 PM
Krinkle updated the task description. (Show Details)Mar 13 2026, 3:46 PM
gerritbot added a comment.Apr 24 2026, 6:00 PM

Change #1277151 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2018 support

https://gerrit.wikimedia.org/r/1277151

gerritbot added a comment.Apr 24 2026, 6:00 PM

Change #1277155 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] Add tests for ES2019 optional catch binding

https://gerrit.wikimedia.org/r/1277155

gerritbot added a comment.Apr 24 2026, 6:00 PM

Change #1277156 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2019 support

https://gerrit.wikimedia.org/r/1277156

gerritbot added a comment.Apr 24 2026, 6:30 PM

Change #1277165 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Support minifying ES2020 optional chaining operator

https://gerrit.wikimedia.org/r/1277165

gerritbot added a comment.Apr 24 2026, 7:01 PM

Change #1277171 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Support ES2020 BigInt literals

https://gerrit.wikimedia.org/r/1277171

gerritbot added a comment.Apr 25 2026, 12:03 PM

Change #1277227 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] Support new forms of import/export from ES2020

https://gerrit.wikimedia.org/r/1277227

gerritbot added a comment.Apr 25 2026, 12:03 PM

Change #1277228 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/libs/Minify@master] Update class documentation for ES2020 support

https://gerrit.wikimedia.org/r/1277228

gerritbot added a comment.Apr 27 2026, 2:36 AM

Change #1195387 had a related patch set uploaded (by Krinkle; author: SD0001):

[mediawiki/libs/Minify@master] tests: Expand tests for `...` object spread and array rest operator

https://gerrit.wikimedia.org/r/1195387

gerritbot added a comment.Apr 27 2026, 2:37 AM

Change #1195387 merged by jenkins-bot:

[mediawiki/libs/Minify@master] tests: Expand tests for `...` object spread and array rest operator

https://gerrit.wikimedia.org/r/1195387

Krinkle edited projects, added: MediaWiki-Core-Platform-Team (Kanban); removed: MediaWiki-Core-Platform-Team (Radar).Apr 27 2026, 2:38 AM
gerritbot added a comment.Apr 28 2026, 1:58 PM

Change #1277151 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2018 support

https://gerrit.wikimedia.org/r/1277151

gerritbot added a comment.Apr 28 2026, 1:59 PM

Change #1277155 merged by jenkins-bot:

[mediawiki/libs/Minify@master] tests: Add coverage for ES2019 optional catch binding

https://gerrit.wikimedia.org/r/1277155

Krinkle updated the task description. (Show Details)Apr 28 2026, 10:51 PM
Krinkle updated the task description. (Show Details)
Krinkle added a comment.Apr 28 2026, 11:05 PM

ES2018: regex lookbehind

As additional test I looked at acorn, a popular JS parser, for some funky test cases.

https://github.com/acornjs/acorn/blob/3f40dbe68408f95c4502b2a03127f91d7c563503/test/tests-regexp-2018.js#L119C7-L119C16

test("/(?<!a)/u", {}, { ecmaVersion: 2018 })

... combined a division on either side, and some nesting, for extra potential confusion of the state machine. This is ultimately doing 1 / Number(RegExp) / 2 which is syntactically valid, albeit logically nonsense.

echo 'var x = [([ 1 / /(?<!a)/u / 2 ])]; console.log(x[0][0]);' | node
NaN
echo 'var x = [([ 1 / /(?<!a)/u / 2 ])]; console.log(x[0][0]);' | bin/minify js | node
NaN
echo 'var x = [([ 1 / /(?<!a)/u / 2 ])]; console.log(x[0][0]);' | bin/minify jsdebug
| stack                                         | last | state                  | token             | type            
| --------------------------------------------- | ---- | ---------------------- | ----------------- | ----------------
|                                               | ;    | STATEMENT              | @0   var          | TYPE_VAR        
|                                               | r    | EXPRESSION             | @4   x            | TYPE_LITERAL    
|                                               | x    | EXPRESSION_OP          | @6   =            | TYPE_BIN_OP     
|                                               | =    | EXPRESSION             | @8   [            | TYPE_PAREN_OPEN 
| EXPRESSION_OP                                 | [    | PAREN_EXPRESSION       | @9   (            | TYPE_PAREN_OPEN 
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | (    | PAREN_EXPRESSION       | @10  [            | TYPE_PAREN_OPEN 
| 2 ..., PAREN_EXPRESSION_OP                    | [    | PAREN_EXPRESSION       | @12  1            | TYPE_LITERAL    
| 2 ..., PAREN_EXPRESSION_OP                    | 1    | PAREN_EXPRESSION_OP    | @14  /            | TYPE_BIN_OP     
| 2 ..., PAREN_EXPRESSION_OP                    | /    | PAREN_EXPRESSION       | @16  /(?<!a)/u    | TYPE_LITERAL    
| 2 ..., PAREN_EXPRESSION_OP                    | u    | PAREN_EXPRESSION_OP    | @26  /            | TYPE_BIN_OP     
| 2 ..., PAREN_EXPRESSION_OP                    | /    | PAREN_EXPRESSION       | @28  2            | TYPE_LITERAL    
| 2 ..., PAREN_EXPRESSION_OP                    | 2    | PAREN_EXPRESSION_OP    | @30  ]            | TYPE_PAREN_CLOSE
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | ]    | PAREN_EXPRESSION_OP    | @31  )            | TYPE_PAREN_CLOSE
| EXPRESSION_OP                                 | )    | PAREN_EXPRESSION_OP    | @32  ]            | TYPE_PAREN_CLOSE
|                                               | ]    | EXPRESSION_OP          | @33  ;            | TYPE_SEMICOLON  
|                                               | ;    | STATEMENT              | @35  console      | TYPE_LITERAL    
|                                               | e    | EXPRESSION_OP          | @42  .            | TYPE_DOT        
|                                               | .    | EXPRESSION_DOT         | @43  log          | TYPE_LITERAL    
|                                               | g    | EXPRESSION_OP          | @46  (            | TYPE_PAREN_OPEN 
| EXPRESSION_OP                                 | (    | PAREN_EXPRESSION       | @47  x            | TYPE_LITERAL    
| EXPRESSION_OP                                 | x    | PAREN_EXPRESSION_OP    | @48  [            | TYPE_PAREN_OPEN 
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | [    | PAREN_EXPRESSION       | @49  0            | TYPE_LITERAL    
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | 0    | PAREN_EXPRESSION_OP    | @50  ]            | TYPE_PAREN_CLOSE
| EXPRESSION_OP                                 | ]    | PAREN_EXPRESSION_OP    | @51  [            | TYPE_PAREN_OPEN 
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | [    | PAREN_EXPRESSION       | @52  0            | TYPE_LITERAL    
| EXPRESSION_OP, PAREN_EXPRESSION_OP            | 0    | PAREN_EXPRESSION_OP    | @53  ]            | TYPE_PAREN_CLOSE
| EXPRESSION_OP                                 | ]    | PAREN_EXPRESSION_OP    | @54  )            | TYPE_PAREN_CLOSE
|                                               | )    | EXPRESSION_OP          | @55  ;            | TYPE_SEMICOLON  
var x=[([1/ /(?<!a)/u/2])];console.log(x[0][0]);

The key part being that the regex literal is parsed as a single literal token and not taken apart or combined with anything.

Krinkle updated the task description. (Show Details)Apr 28 2026, 11:21 PM
Novem_Linguae updated the task description. (Show Details)Apr 28 2026, 11:38 PM
gerritbot added a comment.Apr 28 2026, 11:39 PM

Change #1278715 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/Minify@master] tests: Add coverage for ES2019 U+2028 or U+2029 in string literal

https://gerrit.wikimedia.org/r/1278715

gerritbot added a comment.Apr 28 2026, 11:54 PM

Change #1277156 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2019 support

https://gerrit.wikimedia.org/r/1277156

SD0001 mentioned this in T425099: Add native support for ES2021 to the minifier.May 1 2026, 12:18 PM
SD0001 updated the task description. (Show Details)May 1 2026, 12:26 PM
gerritbot added a comment.May 13 2026, 11:06 AM

Change #1277165 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Support ES2020 optional chaining operator

https://gerrit.wikimedia.org/r/1277165

Krinkle updated the task description. (Show Details)May 14 2026, 11:58 PM
gerritbot added a comment.May 15 2026, 12:59 AM

Change #1287502 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Strip space after exponent and implied zero fraction

https://gerrit.wikimedia.org/r/1287502

gerritbot added a comment.May 15 2026, 1:01 AM

Change #1277171 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Support ES2020 BigInt literals

https://gerrit.wikimedia.org/r/1277171

Krinkle updated the task description. (Show Details)May 15 2026, 2:09 AM
gerritbot added a comment.May 24 2026, 8:46 AM

Change #1287502 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Strip space after exponent and implied zero fraction

https://gerrit.wikimedia.org/r/1287502

Nirmos subscribed.May 28 2026, 10:41 PM
Krinkle updated the task description. (Show Details)Jun 2 2026, 6:58 PM
TehKittyCat subscribed.Jun 3 2026, 5:03 PM
gerritbot added a comment.Jun 11 2026, 12:32 AM

Change #1277227 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Support new forms of import/export from ES2020

https://gerrit.wikimedia.org/r/1277227

gerritbot added a comment.Jun 11 2026, 12:32 AM

Change #1277228 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2020 support

https://gerrit.wikimedia.org/r/1277228

Hakimi97 subscribed.Jun 11 2026, 6:43 AM
Krinkle added a parent task: T395347: Raise Grade A JavaScript requirement from ES2017 to ES2018 (ECMAScript 9).Jun 11 2026, 1:10 PM
Krinkle added a parent task: T419142: Raise Grade A JavaScript requirement from ES2018 to ES2019 (ECMAScript 10).
Krinkle closed this task as Resolved.Fri, Jun 19, 12:44 AM
Krinkle claimed this task.
Krinkle reassigned this task from Krinkle to SD0001.
Krinkle updated the task description. (Show Details)
Krinkle updated Other Assignee, added: Krinkle.
Krinkle mentioned this in T429706: Raise Grade A JavaScript requirement from ES2019 to ES2020 (ECMAScript 11).Fri, Jun 19, 5:31 PM
gerritbot added a comment.Sun, Jun 21, 8:33 AM

Change #1278715 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Document unimplemented whitespace and line terminators (ES2019)

https://gerrit.wikimedia.org/r/1278715

gerritbot added a comment.Fri, Jun 26, 3:52 PM

Change #1305924 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/Minify@master] tests: Add test for ASI after yield without expression (ES2019)

https://gerrit.wikimedia.org/r/1305924

gerritbot added a comment.Fri, Jun 26, 4:20 PM

Change #1305929 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Update wikimedia/minify to 2.11.0

https://gerrit.wikimedia.org/r/1305929

gerritbot added a comment.Fri, Jun 26, 5:18 PM

Change #1305924 merged by jenkins-bot:

[mediawiki/libs/Minify@master] tests: Add test for ASI after yield without expression (ES2019)

https://gerrit.wikimedia.org/r/1305924

gerritbot added a comment.Sat, Jun 27, 5:09 PM

Change #1305929 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Update wikimedia/minify to 2.11.0

https://gerrit.wikimedia.org/r/1305929

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits