| GMikesell-WMF | |
| Oct 1 2024, 11:20 PM |
| F57579930: 2024-10-01_12-57-21.mp4.gif | |
| Oct 1 2024, 11:20 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Other information (browser name/version, screenshots, etc.):
@Andrerodriguex @Aklapper
I would like to show my interest to contribute to this project. My main skill is in Frontend development and I’ll love to fix this bug.
I believe the logo is fixed and that’s why it’s overlapping which it should not be at all
I’d like to be given the go ahead so I can begin familiarizing myself with the code base
The code associated with this feature is in MediaWiki core:
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.special.preferences.ooui/mobile.js
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1180162 had a related patch set uploaded (by AkashKr 282; author: AkashKr 282):
[mediawiki/extensions/AdvancedSearch@master] T376228: Fix dark theme background for namespace selection
Change #1180162 had a related patch set uploaded (by Scardenasmolinar; author: AkashKr 282):
[mediawiki/extensions/AdvancedSearch@master] T376228: Fix dark theme background for namespace selection
Change #1182859 had a related patch set uploaded (by Dev Jadiya; author: Dev Jadiya):
[mediawiki/skins/MinervaNeue@master] This is caused by the CSS filter on the logo creating a new stacking context, which places it visually above the dialog.
Change #1182981 had a related patch set uploaded (by Dev Jadiya; author: Dev Jadiya):
[mediawiki/skins/MinervaNeue@master] This is caused by the CSS filter on the logo creating a new stacking context, which places it visually above the dialog.
Change #1182981 abandoned by Dev Jadiya:
[mediawiki/skins/MinervaNeue@master] This is caused by the CSS filter on the logo creating a new stacking context, which places it visually above the dialog.
Reason:
Duplicate of change 1182859. The correct patch is being updated there.
Hello! I'm ready to review this patch, but wanted clarification about which patch is the one that has been submitted for review?
Thanks!
This creates the problem. Potential fixes:
Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://125c925099.catalyst.wmcloud.org/w/
Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:
Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://902f02f335.catalyst.wmcloud.org/w/
Change #1182859 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix CSS filter creating a new stacking context
Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:
Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:
Change #1207138 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):
[mediawiki/skins/MinervaNeue@master] Revert "Fix CSS filter creating a new stacking context"
Change #1207138 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revert "Fix CSS filter creating a new stacking context"