Page MenuHomePhabricator

[JS] Simplify Integration interface
Closed, ResolvedPublic

Description

Background

During the review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/791319, we simplified the Wikimedia\MetricsPlatform\Integration interface (in the PHP client) to one method, Integration#getContextAttribute(). We should do the same for the JavaScript client.

AC

  • [repos/data-engineering/metrics-platform] Integration#getContextAttribute() is added to the interface
  • [repos/data-engineering/metrics-platform] Logging method(s) is/are moved to a Logger interface
  • [repos/data-engineering/metrics-platform] Integration has as few methods as possible
  • [mediawiki/extensions/EventLogging] MediaWikiMetricsClientIntegration is updated

Notes

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Simplify Integration Interfacerepos/data-engineering/metrics-platform!114sfaciT359618-simplify-integration-interfacemain
Customize query in GitLab

Event Timeline

JVanderhoop-WMF moved this task from Incoming to READY TO GROOM on the Test Kitchen board.

Bringing this to the current sprint to work on it along with T384506: Update event debug logging in EventLogging extension. Some work pending here can be leveraged by the mentioned task

phuedx awarded a token.

This could be deployed right now but we will wait until T384506: Update event debug logging in EventLogging extension is ready to deploy both changes at the same time

Change #1224965 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to 759ce720

https://gerrit.wikimedia.org/r/1224965

Change #1224965 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to 759ce720

https://gerrit.wikimedia.org/r/1224965