Page MenuHomePhabricator

Remove UserLoginComplete hook calls with $direct === false
Closed, ResolvedPublic

Description

LoginSignupSpecialPage::successfulAction() is used both after a successful login, and when visiting the login page while already logged in. That method calls the UserLoginComplete hook, so it will sometimes be invoked in situations which have nothing to do with a login. rMW3617c982c9db: Use AuthManager on special pages added the $direct parameter to differentiate, but it would have been better to just remove the $direct === false case, I don't think it's meaningful.

Tangentially related: that patch removed the "cookie redirect check" step from login, but didn't remove the $wgDisableCookieCheck variable. It probably should have.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 969096 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] specials: Remove calls to UserLoginComplete hook with `direct=false`

https://gerrit.wikimedia.org/r/969096

Change 969101 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] Remove check for irrelevant setting: wgDisableCookieCheck

https://gerrit.wikimedia.org/r/969101

Change 969096 merged by jenkins-bot:

[mediawiki/core@master] specials: Remove calls to UserLoginComplete hook with `direct=false`

https://gerrit.wikimedia.org/r/969096

Change 969101 merged by jenkins-bot:

[mediawiki/core@master] Remove check for irrelevant setting: wgDisableCookieCheck

https://gerrit.wikimedia.org/r/969101

Will create a ticket for dealing with the cleanup in CA and MobileFrontend separately.

Otherwise, this is resolved.