Page MenuHomePhabricator

[wmf.8 testwiki] Post-edit dialog chevron and close buttons not responsive
Closed, InvalidPublicBUG REPORT

Description

Steps to replicate the issue :

  • Finish one of suggested edits - the post edit dialog appears.
  • Click on the chevron button to collapse the dialog - the button is non-responsive.
  • After several clicks, the dialog collapses and the close button is displayed - the post-edit dialog chevron becomes responsive only after the green popup message "You've published an edit!" is gone.
  • Click on the close button - the button is non-responsive.

What should have happened instead?:
The controls for the post-edit dialog should respond to users' actions on the first click.

Notes:

  • The post-edit dialog is not completely non-responsive to the button controls. There are workarounds, for example, clicking in the header area eventually would collapse or close the post-edit dialog, or clicking on the chevron button several times.
  • Level up dialog ("try different task") has the same issue.
  • It's not the issue with doing actions fast

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as Medium priority.May 16 2023, 2:52 PM
kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
kostajh added a subscriber: KStoller-WMF.

@KStoller-WMF should this be high priority?

KStoller-WMF raised the priority of this task from Medium to High.May 16 2023, 3:24 PM

This sounds like it could be frustrating for new editors and potentially impact the Leveling up experiment, so yes, I think we should consider this high priority.
That being said, we have some tight deadlines, so perhaps we can timebox the initial investigation: if there isn't an easy or obvious fix, then we can postpone until after our SDAW deadline.

The issue is still present on desktop and mobile - checked in wmf.19 On mobile the issue might prevent a user to read an article.
There is a similar issue - T342465: [mobile] Add link drawer cannot be minimized after a user interacts with drawer's controls , the similarity is that the drawer's minimizing/close controls are not responsive to users' clicks.

@Etonkovidova I just tested on https://test.wikipedia.org/ and I can't replicate this using Chrome on desktop. Is it only an issue on mobile or certain browsers?

I noticed a different issue: when I complete an "add a link" edit, I don't receive a post edit dialog at all. Is that a quirk of test wiki, or a new bug?

@Etonkovidova I just tested on https://test.wikipedia.org/ and I can't replicate this using Chrome on desktop. Is it only an issue on mobile or certain browsers?

Thank you, @Kirsten for testing! The issue turned out to be tricky to reproduce consistently. I re-checked the issue on testwiki wmf.20 - the issue is not 100% reproducible, but in the majority of cases the issue looks as the following

  • when the green banner is present, the minimizing chevron is not responsive
  • initially it requires two clicks to minimize the post-edit dialog.
  • the first click on the close button will outline it, and the second click on the clickable area will close the post-edit dialog.

Screen Shot 2023-08-07 at 11.10.00 AM.png (1,142×208 px, 41 KB)

  • if only one click on the close button ('x' button) is done, and then a user clicks on the clickable area (including the chevron button), the post-edit dialog will be closed.

Also checked (just in case) T342465: [mobile] Add link drawer cannot be minimized after a user interacts with drawer's controls - the issue is still present.

I noticed a different issue: when I complete an "add a link" edit, I don't receive a post edit dialog at all. Is that a quirk of test wiki, or a new bug?

I checked on testwiki in different browsers and on mobile - the post-edit dialog was always present. The only possible scenario for the post-edit dialog not to appear, it's when the level-up dialog fails to appear. I'll check it today.

Thanks, Elena! OK, hopefully an engineer can replicate and track down the underlying issue!

And hopefully the issue I noticed was just a edge case quirk. I'll see if I can replicate it again.

@Sgs - to summarize what behavior I observe ( testwiki wmf.20 on Chrome or FF). Let's compare with the Help dialog behavior:

  • click on a suggested edit task
  • a page opens with Help panel open
  • if 'x' (close button) is clicked - the panel closes
  • publish an edit. The post-edit dialog and the green banner appear:
    • when the green banner is present, the post-edit dialog is not responsive when clicked (a double-click works)
    • one click on the collapse button won't do anything; clicking again (or a double-click) will collapse the post-edit dialog
    • in a collapsed state, clicking on 'x` won't dismiss the dialog, only a second click will close

Below are gifs to illustrate that double (or more) clicks:

post_edit_dialog_interactions.gif (528×828 px, 435 KB)
post_edit_dialog_interactions2.gif (1,009×763 px, 632 KB)

@Etonkovidova thank you for the detailed steps, I must be missing something because I'm still failing to see this behavior in testwiki. Without knowing yet what is affecting our different results, there are chances the same issue is preventing me to reproduce T342465, more details in T342465#9081167.

@Etonkovidova thank you for the detailed steps, I must be missing something because I'm still failing to see this behavior in testwiki. Without knowing yet what is affecting our different results, there are chances the same issue is preventing me to reproduce T342465, more details in T342465#9081167.

I did some more testing

  • checked my Mac OS in case there are some clicking settings options that might interfere with normal clicking behavior. There are no such settings except Accessibility settings for Pointer control which is set to default.
  • checked on a Windows machine - the issue is not present
  • checked again on Mac OS in different browsers (FF, Chrome, and Safari) - the issue is present on desktop and mobile.

The workaround exists - repetitive clicks will result in an action (co lapsing/un-collapsing or closing the drawer). Since there are some problems with reproducing the issue, and there are no user complaints so far, I'm moving the task to Blocked .

@Etonkovidova I tried to reproduce again with no luck :/. I might be missing something obvious, I suggest we jump into a quick sharing screen sync session, next week. Ty!

The investigation was done (thx, @Sgs) - closing as Invalid - the issue is not reproducible.