Page MenuHomePhabricator

Remove dysfunctional "no outline" mode from template dialog
Closed, ResolvedPublic3 Estimated Story Points

Description

Reasoning: In the original dialog the outline was merely a navigation tool. It was entirely optional. All interactions happened on the right side of the dialog, including adding parameters.

The new design is unusable without the outline because of the checkboxes. Without the outline we can't add parameters that aren't already there.

This is true in all situations, even in the single-template mode used by the Cite extension.

As a result it might be possible to merge the two dialog classes again. But this is outside of the scope of this ticket here.

Note this is purely a tech task. Nothing to demo here, except checking that the citation dialog still works.

Event Timeline

Change 815949 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove dysfunctional "no outline" mode from template dialog

https://gerrit.wikimedia.org/r/815949

Change 815767 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused pieces of code from two-pane layout

https://gerrit.wikimedia.org/r/815767

Change 815949 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dysfunctional "no outline" mode from template dialog

https://gerrit.wikimedia.org/r/815949

Change 815767 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused pieces of code from two-pane layout

https://gerrit.wikimedia.org/r/815767

thiemowmde set the point value for this task to 3.