Maniphest T313111

Error: Call to a member function getContent() on null (from Wikistories Hooks)
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Jul 15 2022, 4:49 AM

Tags

Referenced Files

None

Subscribers

Description

Error

mwversion: 1.39.0-wmf.19
reqId: 0c61df88-5c50-4f38-b7eb-9c9648b2d990
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getContent() on null

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.19/extensions/Wikistories/includes/Hooks.php(122)
#0 /srv/mediawiki/php-1.39.0-wmf.19/includes/deferred/MWCallableUpdate.php(38): MediaWiki\Extension\Wikistories\Hooks::MediaWiki\Extension\Wikistories\{closure}()
...
#7 /srv/mediawiki/php-1.39.0-wmf.19/includes/MediaWiki.php(1124): DeferredUpdates::doUpdates()
#8 /srv/mediawiki/php-1.39.0-wmf.19/includes/MediaWiki.php(846): MediaWiki->restInPeace()
#9 /srv/mediawiki/php-1.39.0-wmf.19/api.php(125): MediaWiki->doPostOutputShutdown()
#10 /srv/mediawiki/php-1.39.0-wmf.19/api.php(45): wfApiMain()
#11 /srv/mediawiki/w/api.php(3): require(string)
#12 {main}

Impact

The failed update is run from a deferred update. This means the surrounding API request (likely an edit) did not fail from the client perspective. However, the onPageSaveComplete hook will have failed and likely not done what it was supposed to.

From a quick glance, it seems like this probably means cache may be stale for certain pages.

https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikistories/+/290ad51a6f45d394fb8836398103d03b3c29d611/includes/Hooks.php#122

Notes

Limited to id.wikipedia.org at the moment.

Details

Request URL: https://id.wikipedia.org/w/api.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Type against LoggerInterface	mediawiki/extensions/Wikistories	master	+2 -2
	Add logging to deferred update	mediawiki/extensions/Wikistories	master	+37 -2

Customize query in gerrit

Related Objects

Mentioned In: T316662: Error: Call to undefined method WikitextContent::getFromArticle()

Event Timeline

Krinkle created this task.Jul 15 2022, 4:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2022, 4:49 AM

Do we know how many instances of this error have happened?

SBisson edited projects, added Wikistories (R2), Inuka-Team (Kanban); removed Wikistories.Jul 15 2022, 1:27 PM

SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Jul 20 2022, 1:16 PM

SBisson claimed this task.Jul 21 2022, 12:50 PM

SBisson triaged this task as Medium priority.

SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 815963 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Add logging to deferred update

https://gerrit.wikimedia.org/r/815963

gerritbot added a project: Patch-For-Review.Jul 21 2022, 1:42 PM

SBisson moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Jul 21 2022, 2:11 PM

Change 815963 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Add logging to deferred update

https://gerrit.wikimedia.org/r/815963

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2022, 7:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 22 2022, 8:00 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Jul 26 2022, 1:49 PM

Change 817760 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Type against LoggerInterface

https://gerrit.wikimedia.org/r/817760

gerritbot added a project: Patch-For-Review.Jul 27 2022, 12:24 PM

Change 817760 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Type against LoggerInterface

https://gerrit.wikimedia.org/r/817760

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 27 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 4:30 PM

(Task remains open as the above is diagnostics, not yet mitigation.)

SBisson mentioned this in T316662: Error: Call to undefined method WikitextContent::getFromArticle().Aug 30 2022, 5:49 PM

SBisson closed this task as a duplicate of T316662: Error: Call to undefined method WikitextContent::getFromArticle().

Change 828062 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Add instrumentation for unexpected content type

https://gerrit.wikimedia.org/r/828062

gerritbot added a project: Patch-For-Review.Aug 30 2022, 5:58 PM