Page MenuHomePhabricator

On function definition page, the input name field should have the literal "input" as a placeholder instead of a value
Closed, ResolvedPublic

Description

{F35307212}

When filling up the list of inputs, each element has a ZObjectSelector to choose the type and a text input field to choose the input name. The input field has the value “input”, instead of being empty and showing “input” as a placeholder.

If the user does nothing, it should NOT be valid on save.

Event Timeline

gengh renamed this task from on function definition, input type should be placeholder and not value to On function definition page, the input name field should have the literal "input" as a placeholder instead of a value.Aug 2 2022, 12:23 PM
gengh updated the task description. (Show Details)
gengh added a project: WikiLambda.

Change 821262 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Remove default string for argument labels.

https://gerrit.wikimedia.org/r/821262

Change 821262 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove default string for argument labels.

https://gerrit.wikimedia.org/r/821262

This ticket is not fully fixed yet - the above patch ensures the user must enter a label for the first argument, but doesn't ensure it for subsequent arguments.

Change 826550 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Prevent publishing with empty input labels or types.

https://gerrit.wikimedia.org/r/826550

Change 826550 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Prevent publishing with empty argument labels or types.

https://gerrit.wikimedia.org/r/826550