Page MenuHomePhabricator
Create Task
Maniphest T310324

Create and use "Invalid Programming Language" Errors
Closed, ResolvedPublic
Actions

Description

We need to create and use ZErrors that represents "this programming language is not supported" and/or "programming language not found". Not to be confused with Z540 (Invalid Language Code) and Z541 (Language Code Not Found), which are for natural languages.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Change evaluate error type from generic parser error to specific "invalid programming language" error.Mary Yangmediawiki/services/function-evaluatormaster+2 -6
Update function-schemata sub-module to HEAD (04570e8)Jforrestermediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (04570e8)Jforrestermediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (04570e8)Jforrestermediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (04570e8)Jforrestermediawiki/tools/wikilambda-climaster+1 -1
definitions: Add Z558/Invalid programming language errorTeleosteenmediawiki/services/function-schematamaster+46 -1
Customize query in gerrit

Related Objects

Event Timeline

• maryyang created this task.Jun 10 2022, 1:01 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJun 10 2022, 1:01 AM
• maryyang triaged this task as Low priority.Jun 10 2022, 1:02 AM
Jdforrester-WMF added projects: Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team.Jun 15 2022, 5:08 PM
DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Jun 21 2022, 6:32 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase κ – Clean-up); removed: Abstract Wikipedia team.
Teleosteen claimed this task.Jul 7 2022, 2:51 PM
Teleosteen subscribed.

If that's OK, I can take this bug.

However, I miss some context. Could you, if you don't mind, describe me a scenario for such an error? (I am a new contributor, thanks in advance :-) )

• maryyang added a comment.Jul 10 2022, 1:26 AM

Hi @Teleosteen, here is an example of where this error would be used: evaluate.js. If you search for this bug ID, you will find two scenarios where this error type is needed: when a function definition specifies a programming language that does not exist, or does not have an executor built-in. I hope this answers your questions. Cheers!

gerritbot added a comment.Jul 14 2022, 8:51 AM

Change 813827 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/services/function-schemata@master] definitions: Add Z558/Invalid programming language error

https://gerrit.wikimedia.org/r/813827

gerritbot added a project: Patch-For-Review.Jul 14 2022, 8:51 AM
Teleosteen added a comment.EditedJul 14 2022, 8:54 AM

Thanks @maryyang

This is my patch. I hope this is what was expected :).

Thanks in advance for your review 🙏

Jdforrester-WMF updated the task description. (Show Details)Jul 18 2022, 5:10 PM
gerritbot added a comment.Jul 18 2022, 5:11 PM

Change 813827 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Add Z558/Invalid programming language error

https://gerrit.wikimedia.org/r/813827

Jdforrester-WMF mentioned this in rMSFS04570e8f6cd0: definitions: Add Z558/Invalid programming language error.Jul 18 2022, 5:11 PM
gerritbot added a comment.Jul 18 2022, 5:16 PM

Change 814863 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/814863

gerritbot added a comment.Jul 20 2022, 1:22 PM

Change 815714 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815714

gerritbot added a comment.Jul 20 2022, 1:23 PM

Change 815716 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815716

gerritbot added a comment.Jul 20 2022, 1:25 PM

Change 815718 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815718

gerritbot added a comment.Jul 20 2022, 1:59 PM

Change 815718 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815718

gerritbot added a comment.Jul 20 2022, 2:00 PM

Change 815714 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815714

Jdforrester-WMF mentioned this in rMTWC38c13c86eeca: Update function-schemata sub-module to HEAD (04570e8).Jul 20 2022, 2:01 PM
Jdforrester-WMF mentioned this in rMSFOa01acd9f2545: Update function-schemata sub-module to HEAD (04570e8).
gerritbot added a comment.Jul 20 2022, 2:02 PM

Change 815716 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/815716

Jdforrester-WMF mentioned this in rMSFE96a976ecd472: Update function-schemata sub-module to HEAD (04570e8).Jul 20 2022, 2:03 PM
gerritbot added a comment.Jul 20 2022, 2:13 PM

Change 814863 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (04570e8)

https://gerrit.wikimedia.org/r/814863

• maryyang added a comment.Jul 20 2022, 2:22 PM

I'll finish the last part of this task: Use in function-evaluator.

• maryyang claimed this task.Jul 20 2022, 2:23 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 2:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 3:00 PM
gerritbot added a comment.Jul 20 2022, 10:54 PM

Change 815814 had a related patch set uploaded (by Mary Yang; author: Mary Yang):

[mediawiki/services/function-evaluator@master] Change evaluate error type from generic parser error to specific "invalid programming language" error.

https://gerrit.wikimedia.org/r/815814

gerritbot added a project: Patch-For-Review.Jul 20 2022, 10:54 PM
gerritbot added a comment.Jul 21 2022, 1:35 PM

Change 815814 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Change evaluate error type from generic parser error to specific "invalid programming language" error.

https://gerrit.wikimedia.org/r/815814

• maryyang mentioned this in rMSFEa117df1defe1: Change evaluate error type from generic parser error to specific.Jul 21 2022, 1:36 PM
Jdforrester-WMF closed this task as Resolved.Jul 21 2022, 1:36 PM
Jdforrester-WMF updated the task description. (Show Details)

Thank you both!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits