Page MenuHomePhabricator
Create Task
Maniphest T305232

An incomplete new Vector appearance is served when invalid 'useskin' query param is used
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Jdlrobson
Authored By
Func
Apr 1 2022, 9:43 AM
Project Tags
Referenced Files
F35047581: Screen Recording 2022-04-11 at 6.16.40 PM.mov.gif
Apr 12 2022, 1:24 AM
F35033814: Screen Shot 2022-04-01 at 8.36.56 AM.png
Apr 1 2022, 3:38 PM
F35033812: Screen Shot 2022-04-01 at 8.36.40 AM.png
Apr 1 2022, 3:38 PM
F35033808: Screen Shot 2022-04-01 at 8.33.45 AM.png
Apr 1 2022, 3:35 PM
Subscribers
• Aklapper
Edtadros
Func
Jdlrobson

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
An incomplete new Vector appearance is served, especially the sidebar and language selector.

What should have happened instead?:
Fallback to the site's default skin, Vector 2022 for the beta cluster, and the appearance are complete.

  • QA steps ***

A screenshot of https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page should be identical to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskin=foo

QA Results - Prod

ACStatusDetails
1❓T305232#7847005

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop the LatestSkinVersionRequirementJdlrobsonmediawiki/skins/Vectormaster+30 -246
Customize query in gerrit

Related Objects
Search...

Event Timeline

Func created this task.Apr 1 2022, 9:43 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptApr 1 2022, 9:43 AM
Func added a project: Vector (legacy skin).Apr 1 2022, 9:43 AM
Jdlrobson subscribed.Apr 1 2022, 3:35 PM
This comment was removed by Jdlrobson.
Jdlrobson added a project: Web-Team-Backlog-Archived.Apr 1 2022, 3:35 PM
Jdlrobson added a comment.Apr 1 2022, 3:38 PM

With bad query string parameter:

Screen Shot 2022-04-01 at 8.36.40 AM.png (2,850×1,476 px, 736 KB)

With good query string parameter:

Screen Shot 2022-04-01 at 8.36.56 AM.png (2,866×1,522 px, 807 KB)

Can replicate locally, have a theory about what's happening here.

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed: Web-Team-Backlog-Archived.Apr 1 2022, 3:38 PM
gerritbot added a comment.Apr 1 2022, 3:55 PM

Change 776226 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop the LatestSkinVersionRequirement

https://gerrit.wikimedia.org/r/776226

gerritbot added a project: Patch-For-Review.Apr 1 2022, 3:55 PM
Jdlrobson triaged this task as High priority.Apr 1 2022, 3:57 PM
Jdlrobson mentioned this in T302627: Skin continously switch to Vector 2022 despite (global) preferences.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson mentioned this in T305262: Jumbo size text and icons in personal menu intermittently in Vector skin.Apr 1 2022, 10:28 PM
ovasileva added a parent task: T304169: [Goal] Begin table of contents A/B test.Apr 4 2022, 9:57 AM
ovasileva moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Apr 4 2022, 5:43 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Apr 4 2022, 7:22 PM
gerritbot added a comment.Apr 4 2022, 8:18 PM

Change 776226 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Drop the LatestSkinVersionRequirement

https://gerrit.wikimedia.org/r/776226

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2022, 8:31 PM
Jdlrobson assigned this task to Edtadros.Apr 4 2022, 8:57 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Apr 7 2022, 5:08 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.EditedApr 12 2022, 1:24 AM
Edtadros subscribed.

Test Result - Prod

Status: ❓
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.org/wiki/Main_Page
Visit https://en.wikipedia.org/wiki/Main_Page?useskin=foo
Compare the difference in appearance.
What happens?:
❓ AC1: Fallback to the site's default skin, Vector legacy for prod, and the appearance are complete.
This reverted to Vector legacy even though my selected skin in preferences/appearance was 2022.

Screen Recording 2022-04-11 at 6.16.40 PM.mov.gif (1,210×680 px, 1 MB)

@Jdlrobson, I'm not moving this into Ready for Signoff because I'm not sure how valid the test in Prod is since the default skin is not Legacy 2022. If you're good with it, let me know.

Edtadros updated the task description. (Show Details)Apr 12 2022, 1:26 AM
Jdlrobson mentioned this in T305966: Users who have selected legacy Vector, seeing Vector 2022 on certain page views.Apr 12 2022, 4:52 PM
Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Apr 12 2022, 5:09 PM

That LGTM. When foo is given it doesn't match a skin so we fall back to the default skin for this wiki which in this case is legacy.

Jdlrobson closed this task as Resolved.Apr 12 2022, 5:09 PM
Krinkle mentioned this in T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.Jul 2 2022, 3:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits