Page MenuHomePhabricator
Create Task
Maniphest T294703

Hard deprecate and remove the deprecated global shell functions
Open, Needs TriagePublic
Actions

Description

The following global functions are soft deprecated. Their usages should be replaced, then they should start emit deprecation warnings. And eventually they should be removed.

  • wfEscapeShellArg
  • wfShellExec
  • wfShellExecWithStderr
  • wfShellWikiCmd

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated global shell functionsmediawiki/extensions/TimedMediaHandlermaster+15 -14
GlobalIdGenerator: Convert deprecated shell global functions calls to Shell classmediawiki/coremaster+4 -2
UploadVerification: Convert remaining wfShell* commands to Shell classmediawiki/coremaster+3 -2
Replace usages of Shell related globalsmediawiki/extensions/Scribuntomaster+17 -5
Replace global shell functions with Shell classmediawiki/extensions/PdfHandlermaster+7 -6
Drop usage of Shell-related globalsmediawiki/extensions/WikimediaMaintenancemaster+6 -5
Replace deprecated function wfEscapeShellArg with Shell::escape()mediawiki/extensions/WikimediaMaintenancemaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.Oct 31 2021, 12:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2021, 12:05 PM
gerritbot added a comment.Oct 31 2021, 12:10 PM

Change 735739 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated function wfEscapeShellArg with Shell::escape()

https://gerrit.wikimedia.org/r/735739

gerritbot added a project: Patch-For-Review.Oct 31 2021, 12:10 PM
Aklapper added a project: MediaWiki-extensions-WikimediaMaintenance.Nov 1 2021, 9:06 AM
gerritbot added a comment.Dec 24 2021, 9:42 PM

Change 735739 abandoned by Zabe:

[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated function wfEscapeShellArg with Shell::escape()

Reason:

https://gerrit.wikimedia.org/r/735739

Maintenance_bot removed a project: Patch-For-Review.Dec 24 2021, 10:10 PM
Krinkle moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.Mar 27 2024, 6:47 PM
lcawte subscribed.Mar 30 2026, 6:38 AM
lcawte added a parent task: T42485: Clean up deprecated functions in GlobalFunctions.php.Mar 30 2026, 11:50 AM
gerritbot added a comment.Mar 30 2026, 5:50 PM

Change #1264641 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/PdfHandler@master] Replace global shell functions with Shell class

https://gerrit.wikimedia.org/r/1264641

gerritbot added a project: Patch-For-Review.Mar 30 2026, 5:50 PM

Change #1264636 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/WikimediaMaintenance@master] Drop usage of Shell-related globals

https://gerrit.wikimedia.org/r/1264636

gerritbot added a comment.Mar 30 2026, 6:08 PM

Change #1264636 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Drop usage of Shell-related globals

https://gerrit.wikimedia.org/r/1264636

gerritbot added a comment.Mar 30 2026, 6:21 PM

Change #1264641 merged by jenkins-bot:

[mediawiki/extensions/PdfHandler@master] Replace global shell functions with Shell class

https://gerrit.wikimedia.org/r/1264641

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2026, 6:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 30 2026, 7:00 PM
gerritbot added a comment.Apr 1 2026, 9:27 PM

Change #1264322 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/Scribunto@master] Replace usages of Shell related globals

https://gerrit.wikimedia.org/r/1264322

gerritbot added a project: Patch-For-Review.Apr 1 2026, 9:27 PM
gerritbot added a comment.Apr 9 2026, 3:27 PM

Change #1264322 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace usages of Shell related globals

https://gerrit.wikimedia.org/r/1264322

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2026, 3:31 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Apr 9 2026, 4:00 PM
gerritbot added a comment.Apr 9 2026, 5:22 PM

Change #1269539 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/TimedMediaHandler@master] [UNTESTED] Replace deprecated global shell functions

https://gerrit.wikimedia.org/r/1269539

gerritbot added a project: Patch-For-Review.Apr 9 2026, 5:22 PM
gerritbot added a comment.Sun, May 3, 1:51 PM

Change #1281992 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] UploadVerification: Convert remaining wfShell* commands to Shell class

https://gerrit.wikimedia.org/r/1281992

gerritbot added a comment.Mon, May 11, 4:43 PM

Change #1285863 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/core@master] GlobalIdGenerator: Convert deprecated shell global functions calls to Shell class

https://gerrit.wikimedia.org/r/1285863

lcawte added a comment.Wed, May 13, 11:56 AM

Should now be patches for review against all WMF-deployed code & core per codesearch.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits