Flow's Exporter class extends WikiExporter and needs to have it's constructor arguments updated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Zabe
	Sep 19 2021, 9:03 AM

Description

In rMW2fbf13812ad8: WikiExporter: inject services services were injected into WikiExporter. Flow' Exporter class extends WikiExporter and thus needs it's constructor arguments updated.

Phan is currently also failing:

18:43:27 includes/Dump/Exporter.php:89 PhanParamTooFew Call with 3 arg(s) to \WikiExporter::__construct(\Wikimedia\Rdbms\IDatabase $db, \MediaWiki\HookContainer\HookContainer $hookContainer, \MediaWiki\Revision\RevisionStore $revisionStore, \TitleParser $titleParser, array|int $history = self::CURRENT, int $text = self::TEXT, ?array $limitNamespaces = null) which requires 4 arg(s) defined at ../../includes/export/WikiExporter.php:116

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update constructor arguments of Exporter to match WikiExporter	mediawiki/extensions/Flow	master	+32 -4

Customize query in gerrit

Related Objects

Mentioned Here: rMW2fbf13812ad8: WikiExporter: inject services

Event Timeline

Zabe created this task.Sep 19 2021, 9:03 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 19 2021, 9:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Zabe triaged this task as High priority.Sep 19 2021, 9:13 AM

Change 722062 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Update constructor arguments of Exporter to match WikiExporter

https://gerrit.wikimedia.org/r/722062

gerritbot added a project: Patch-For-Review.Sep 19 2021, 9:15 AM

Zabe updated the task description. (Show Details)Sep 19 2021, 9:17 AM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 20 2021, 1:29 AM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 722062 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Update constructor arguments of Exporter to match WikiExporter

https://gerrit.wikimedia.org/r/722062

Zabe closed this task as Resolved.Sep 20 2021, 3:48 PM

Zabe claimed this task.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 20 2021, 4:00 PM

Zabe added a project: ci-test-error.Sep 20 2021, 4:08 PM

Zabe removed a project: Patch-For-Review.

Zabe removed a project: User-Zabe.Apr 13 2022, 12:49 AM

Flow's Exporter class extends WikiExporter and needs to have it's constructor arguments updatedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Flow's Exporter class extends WikiExporter and needs to have it's constructor arguments updated
Closed, ResolvedPublic
Actions