Page MenuHomePhabricator
Create Task
Maniphest T276328

Collect PrefUpdate events for page previews
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Add the page previews (merged) preference to the inclusion list for tracking in WikimediaEvents, using the PrefUpdate schema.

Don't bother with aggregation yet.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Reannotate popups related preference trackingmediawiki/extensions/WikimediaEventsmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Mar 3 2021, 2:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2021, 2:09 PM
awight set the point value for this task to 1.Mar 3 2021, 2:19 PM
Tobi_WMDE_SW removed a project: Unplanned-Sprint-Work.Mar 3 2021, 2:39 PM
Andrew-WMDE claimed this task.Mar 4 2021, 8:29 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-03 board.
gerritbot added a comment.Mar 4 2021, 9:52 AM

Change 668351 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/WikimediaEvents@master] Reannotate popups related preference tracking

https://gerrit.wikimedia.org/r/668351

gerritbot added a project: Patch-For-Review.Mar 4 2021, 9:52 AM
Andrew-WMDE added a comment.Mar 4 2021, 10:11 AM

Looks like the popups preference (which is also now the joint preference) is a already being tracked.

https://phabricator.wikimedia.org/diffusion/EWMV/browse/master/includes/PrefUpdateInstrumentation.php$76
https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/includes/PopupsContext.php$57

Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-03-03 board.Mar 4 2021, 10:11 AM
gerritbot added a comment.Mar 4 2021, 10:37 AM

Change 668351 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Reannotate popups related preference tracking

https://gerrit.wikimedia.org/r/668351

awight moved this task from Review to Done on the WMDE-TechWish-Sprint-2021-03-03 board.Mar 4 2021, 10:58 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 4 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 11:10 AM
Lena_WMDE moved this task from Backlog to Doing on the Reference Previews board.Mar 4 2021, 2:08 PM
Lena_WMDE mentioned this in T277641: Collect PrefUpdate events for reference previews, remove for page previews.Mar 17 2021, 9:21 AM
Lena_WMDE closed this task as Resolved.May 17 2021, 9:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits