User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk were soft deprecated and now need to be hard deprecated. So we need to remove using from:
- (Skin) Nostalgia
- (Skin) Tempo
- (Skin) BlueSky
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release | |||
| Open | None | T274211 Finish hard-deprecation and removal of User methods depecated prior to MW 1.36 | |||
| Resolved | Vlad.shapik | T276322 Avoid using User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk |
Event Timeline
Comment Actions
Change 668086 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/Nostalgia@master] Avoid using User::getNewTalk
Comment Actions
Change 668086 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Avoid using User::getNewTalk
Comment Actions
Change 668523 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/skins/BlueSky@master] Remove BC hacks
Comment Actions
Change 668524 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/skins/Tempo@master] Remove BC hacks and set MW version
Comment Actions
Change 668523 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Remove BC hacks
Comment Actions
Change 668524 merged by jenkins-bot:
[mediawiki/skins/Tempo@master] Remove BC hacks and set MW version
Comment Actions
Change 678586 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/core@master] UserTests: create test cases to check triggering of the deprecation warning in the User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk
Comment Actions
Change 678586 abandoned by Vlad.shapik:
[mediawiki/core@master] UserTest: create test cases to check triggering of the deprecation warning in the User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk
Reason:
There is no need to add these tests.
Comment Actions
There aren't any usages of User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk in the core. These methods are hard deprecated, so the ticket could be marked as a resolved.