Parser tests are broken for GrowthExperiments
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	kostajh
	Oct 8 2020, 11:49 AM

Description

 There were 222 failures:

12:26:39 1) ParserIntegrationTest::testParse with data set "bookReferencing.txt: Book Referencing attribute rejected by default" ('[details omitted]')
12:26:39 HttpRequestFactory not supported
12:26:39 
12:26:39 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:1077
12:26:39 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
12:26:39 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
12:26:39 /workspace/src/includes/MediaWikiServices.php:793
12:26:39 /workspace/src/extensions/GrowthExperiments/ServiceWiring.php:58
12:26:39 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
12:26:39 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
12:26:39 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:424
12:26:39 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:161
12:26:39 /workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php:102
12:26:39 /workspace/src/includes/HookContainer/HookContainer.php:463
12:26:39 /workspace/src/includes/HookContainer/HookContainer.php:159
12:26:39 /workspace/src/includes/HookContainer/HookRunner.php:2578
12:26:39 /workspace/src/includes/cache/MessageCache.php:929
12:26:39 /workspace/src/includes/language/Message.php:1291
12:26:39 /workspace/src/includes/language/Message.php:1013
12:26:39 /workspace/src/extensions/Cite/src/FootnoteMarkFormatter.php:101
12:26:39 /workspace/src/extensions/Cite/src/FootnoteMarkFormatter.php:60
12:26:39 /workspace/src/extensions/Cite/src/Cite.php:373
12:26:39 /workspace/src/extensions/Cite/src/Cite.php:129
12:26:39 /workspace/src/extensions/Cite/src/Hooks/CiteParserTagHooks.php:41
12:26:39 /workspace/src/includes/parser/Parser.php:3925
12:26:39 /workspace/src/includes/parser/PPFrame_Hash.php:330
12:26:39 /workspace/src/includes/parser/Parser.php:2874
12:26:39 /workspace/src/includes/parser/Parser.php:1547
12:26:39 /workspace/src/includes/parser/Parser.php:646
12:26:39 /workspace/src/tests/parser/ParserTestRunner.php:915
12:26:39 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:60
12:26:39 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
12:26:39 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
12:26:39 /workspace/src/maintenance/doMaintenance.php:106
12:26:39 === Logs generated by test case
12:26:39 [wfDebug] [debug] ParserTestRunner::runTest: running Book Referencing attribute rejected by default {"private":false}
12:26:39 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
12:26:39 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
12:26:39 ===

I think this is due to the HTTP change in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626348. For some reason GrowthExperiments GrowthExperimentsConfigurationLoader service is triggered by a hook, and since we haven't mocked the HTTP request factory, the tests fail. I'm working on it in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/632890

Carried over from T248180

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Tests: Mock HttpRequestFactory and switch to UserFactory	mediawiki/extensions/GrowthExperiments	master	+22 -3
	Revert "PHPUnit: prevent HTTP requests"	mediawiki/core	master	+4 -47

Customize query in gerrit

Related Objects

Mentioned In: T248180: parser tests running under phpunit are broken in extensions
Mentioned Here: T248180: parser tests running under phpunit are broken in extensions

Event Timeline

kostajh created this task.Oct 8 2020, 11:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2020, 11:49 AM

kostajh mentioned this in T248180: parser tests running under phpunit are broken in extensions.Oct 8 2020, 11:49 AM

Change 632890 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Tests: Mock HttpRequestFactory and switch to UserFactory

https://gerrit.wikimedia.org/r/632890

gerritbot added a project: Patch-For-Review.Oct 8 2020, 11:50 AM

Jdforrester-WMF subscribed.Oct 8 2020, 4:54 PM

Change 632820 had a related patch set uploaded (by Jforrester; owner: Kosta Harlan):
[mediawiki/core@master] Revert "PHPUnit: prevent HTTP requests"

https://gerrit.wikimedia.org/r/632820

Either High or UBN. :-(

Urbanecm subscribed.Oct 8 2020, 5:51 PM

Change 632820 merged by jenkins-bot:
[mediawiki/core@master] Revert "PHPUnit: prevent HTTP requests"

https://gerrit.wikimedia.org/r/632820

Change 632825 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Revert "Revert "PHPUnit: prevent HTTP requests""

https://gerrit.wikimedia.org/r/632825

Change 632890 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Tests: Mock HttpRequestFactory and switch to UserFactory

https://gerrit.wikimedia.org/r/632890

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 8 2020, 9:00 PM

Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Oct 23 2020, 5:45 PM